add IniTestTrait to easy backup ini values

Author: michalsn

system/Test/IniTestTrait.php

@@ -0,0 +1,33 @@
+<?php
+
+/**
+ * This file is part of CodeIgniter 4 framework.
+ *
+ * (c) CodeIgniter Foundation <admin@codeigniter.com>
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
+namespace CodeIgniter\Test;
+
+trait IniTestTrait
+{
+    private array $iniSettings = [];
+
+    private function backupIniValues(array $keys): void
+    {
+        foreach ($keys as $key) {
+            $this->iniSettings[$key] = ini_get($key);
+        }
+    }
+
+    private function restoreIniValues(): void
+    {
+        foreach ($this->iniSettings as $key => $value) {
+            ini_set($key, $value);
+        }
+
+        $this->iniSettings = [];
+    }
+}

…pport/Debug/highlightFile_pre_8_3_0.html …pport/Debug/highlightFile_pre_80300.htmltests/_support/Debug/highlightFile_pre_8_3_0.html renamed to tests/_support/Debug/highlightFile_pre_80300.html tests/_support/Debug/highlightFile_pre_8_3_0.html renamed to tests/_support/Debug/highlightFile_pre_80300.html

@@ -14,6 +14,7 @@
 use App\Controllers\Home;
 use CodeIgniter\Exceptions\PageNotFoundException;
 use CodeIgniter\Test\CIUnitTestCase;
+use CodeIgniter\Test\IniTestTrait;
 use CodeIgniter\Test\StreamFilterTrait;
 use Config\Exceptions as ExceptionsConfig;
 use Config\Services;
@@ -27,6 +28,7 @@
 final class ExceptionHandlerTest extends CIUnitTestCase
 {
     use StreamFilterTrait;
+    use IniTestTrait;
 
     private ExceptionHandler $handler;
 
@@ -240,14 +242,20 @@ public function testMaskSensitiveDataTraceDataKey(): void
 
     public function testHighlightFile(): void
     {
+        $this->backupIniValues([
+            'highlight.comment', 'highlight.default', 'highlight.html', 'highlight.keyword', 'highlight.string',
+        ]);
+
         $highlightFile = $this->getPrivateMethodInvoker($this->handler, 'highlightFile');
         $result        = $highlightFile(SUPPORTPATH . 'Controllers' . DIRECTORY_SEPARATOR . 'Hello.php', 16);
-        $resultFile    = version_compare(PHP_VERSION, '8.3.0', '<') ?
-            'highlightFile_pre_8_3_0.html' :
+        $resultFile    = PHP_VERSION_ID < 80300 ?
+            'highlightFile_pre_80300.html' :
             'highlightFile.html';
 
         $expected = file_get_contents(SUPPORTPATH . 'Debug' . DIRECTORY_SEPARATOR . $resultFile);
 
         $this->assertSame($expected, $result);
+
+        $this->restoreIniValues();
     }
 }

tests/system/Debug/ExceptionHandlerTest.php

@@ -0,0 +1,41 @@
+<?php
+
+/**
+ * This file is part of CodeIgniter 4 framework.
+ *
+ * (c) CodeIgniter Foundation <admin@codeigniter.com>
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
+namespace CodeIgniter\Test;
+
+use ReflectionException;
+
+/**
+ * @internal
+ */
+final class IniTestTraitTest extends CIUnitTestCase
+{
+    use IniTestTrait;
+
+    /**
+     * @throws ReflectionException
+     */
+    public function testBackupAndRestoreIniValues(): void
+    {
+        $this->backupIniValues(['highlight.default']);
+        $backup = $this->getPrivateProperty($this, 'iniSettings');
+        $this->assertSame('#0000BB', $backup['highlight.default']);
+
+        ini_set('highlight.default', '#FFFFFF');
+        $this->assertSame('#FFFFFF', ini_get('highlight.default'));
+
+        $this->restoreIniValues();
+        $this->assertSame('#0000BB', ini_get('highlight.default'));
+
+        $backup = $this->getPrivateProperty($this, 'iniSettings');
+        $this->assertSame([], $backup);
+    }
+}