Merge pull request #7091 from kenjis/test-add-todo-for-route-placeholder-any

test: add `@TODO` to incorrect `(:any)` usages

Author: kenjis

tests/system/CommonFunctionsTest.php

@@ -266,6 +266,8 @@ public function testRouteTo()
     {
         // prime the pump
         $routes = service('routes');
+        // @TODO Do not put any placeholder after (:any).
+        //       Because the number of parameters passed to the controller method may change.
         $routes->add('path/(:any)/to/(:num)', 'myController::goto/$1/$2');
 
         $this->assertSame('/path/string/to/13', route_to('myController::goto', 'string', 13));
@@ -275,6 +277,8 @@ public function testRouteToInCliWithoutLocaleInRoute()
     {
         Services::createRequest(new App(), true);
         $routes = service('routes');
+        // @TODO Do not put any placeholder after (:any).
+        //       Because the number of parameters passed to the controller method may change.
         $routes->add('path/(:any)/to/(:num)', 'myController::goto/$1/$2');
 
         $this->assertSame('/path/string/to/13', route_to('myController::goto', 'string', 13));
@@ -284,6 +288,8 @@ public function testRouteToInCliWithLocaleInRoute()
     {
         Services::createRequest(new App(), true);
         $routes = service('routes');
+        // @TODO Do not put any placeholder after (:any).
+        //       Because the number of parameters passed to the controller method may change.
         $routes->add('{locale}/path/(:any)/to/(:num)', 'myController::goto/$1/$2', ['as' => 'path-to']);
 
         $this->assertSame(
@@ -296,6 +302,8 @@ public function testRouteToWithUnsupportedLocale()
     {
         Services::createRequest(new App(), false);
         $routes = service('routes');
+        // @TODO Do not put any placeholder after (:any).
+        //       Because the number of parameters passed to the controller method may change.
         $routes->add('{locale}/path/(:any)/to/(:num)', 'myController::goto/$1/$2', ['as' => 'path-to']);
 
         $this->assertSame(

tests/system/Helpers/URLHelper/MiscUrlTest.php

@@ -835,6 +835,8 @@ public function testUrlTo(string $expected, string $input, ...$args)
         $_SERVER['HTTP_HOST'] = 'example.com';
 
         $routes = service('routes');
+        // @TODO Do not put any placeholder after (:any).
+        //       Because the number of parameters passed to the controller method may change.
         $routes->add('path/(:any)/to/(:num)', 'myController::goto/$1/$2', ['as' => 'gotoPage']);
         $routes->add('route/(:any)/to/(:num)', 'myOtherController::goto/$1/$2');
 

tests/system/Router/RouteCollectionReverseRouteTest.php

@@ -56,6 +56,8 @@ public function testReverseRoutingFindsSimpleMatch()
     {
         $routes = $this->getCollector();
 
+        // @TODO Do not put any placeholder after (:any).
+        //       Because the number of parameters passed to the controller method may change.
         $routes->add('path/(:any)/to/(:num)', 'myController::goto/$1/$2');
 
         $match = $routes->reverseRoute('myController::goto', 'string', 13);
@@ -67,6 +69,8 @@ public function testReverseRoutingWithLocaleAndFindsSimpleMatch()
     {
         $routes = $this->getCollector();
 
+        // @TODO Do not put any placeholder after (:any).
+        //       Because the number of parameters passed to the controller method may change.
         $routes->add('{locale}/path/(:any)/to/(:num)', 'myController::goto/$1/$2');
 
         $match = $routes->reverseRoute('myController::goto', 'string', 13);
@@ -78,6 +82,8 @@ public function testReverseRoutingReturnsFalseWithBadParamCount()
     {
         $routes = $this->getCollector();
 
+        // @TODO Do not put any placeholder after (:any).
+        //       Because the number of parameters passed to the controller method may change.
         $routes->add('path/(:any)/to/(:num)', 'myController::goto/$1');
 
         $this->assertFalse($routes->reverseRoute('myController::goto', 'string', 13));
@@ -87,6 +93,8 @@ public function testReverseRoutingReturnsFalseWithNoMatch()
     {
         $routes = $this->getCollector();
 
+        // @TODO Do not put any placeholder after (:any).
+        //       Because the number of parameters passed to the controller method may change.
         $routes->add('path/(:any)/to/(:num)', 'myController::goto/$1/$2');
 
         $this->assertFalse($routes->reverseRoute('myBadController::goto', 'string', 13));
@@ -96,6 +104,8 @@ public function testReverseRoutingThrowsExceptionWithBadParamTypes()
     {
         $routes = $this->getCollector();
 
+        // @TODO Do not put any placeholder after (:any).
+        //       Because the number of parameters passed to the controller method may change.
         $routes->add('path/(:any)/to/(:num)', 'myController::goto/$1/$2');
 
         $this->expectException(RouterException::class);

tests/system/Router/RouteCollectionTest.php

@@ -889,6 +889,8 @@ public function testNamedRoutesFillInParams()
     {
         $routes = $this->getCollector();
 
+        // @TODO Do not put any placeholder after (:any).
+        //       Because the number of parameters passed to the controller method may change.
         $routes->add('path/(:any)/to/(:num)', 'myController::goto/$1/$2', ['as' => 'namedRoute']);
 
         $match = $routes->reverseRoute('namedRoute', 'string', 13);
@@ -900,6 +902,8 @@ public function testNamedRoutesWithLocaleAndFillInParams()
     {
         $routes = $this->getCollector();
 
+        // @TODO Do not put any placeholder after (:any).
+        //       Because the number of parameters passed to the controller method may change.
         $routes->add('{locale}/path/(:any)/to/(:num)', 'myController::goto/$1/$2', ['as' => 'namedRoute']);
 
         $match = $routes->reverseRoute('namedRoute', 'string', 13);

tests/system/View/ParserPluginTest.php

@@ -96,6 +96,8 @@ public function testRoute()
     {
         // prime the pump
         $routes = service('routes');
+        // @TODO Do not put any placeholder after (:any).
+        //       Because the number of parameters passed to the controller method may change.
         $routes->add('path/(:any)/to/(:num)', 'myController::goto/$1/$2');
 
         $template = '{+ route myController::goto string 13 +}';