Skip to content

Commit 3b416c8

Browse files
kenjismichalsn
andcommitted
docs: improve explanation
Apply suggestions from code review Co-authored-by: Michal Sniatala <michal@sniatala.pl>
1 parent 69a5c29 commit 3b416c8

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

user_guide_src/source/changelogs/v4.3.4.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,11 @@ Forge::modifyColumn()
4444
to a bug, in previous versions, SQLite3/Postgres/SQLSRV might change
4545
``NULL``/``NOT NULL`` unpredictably.
4646
- In previous versions, the OCI8 driver did not change ``NULL``/``NOT NULL``
47-
when you don't specify ``null`` value.
47+
when you don't specify the ``null`` key.
4848
- Now in all database drivers ``$forge->modifyColumn()`` always sets ``NULL``
49-
when you don't specify ``null`` value.
49+
when you don't specify the ``null`` key.
5050
- The ``NULL``/``NOT NULL`` change may still be unexpectedly, it is recommended
51-
to always specifiy ``null`` value.
51+
to always specify the ``null`` key.
5252

5353
Message Changes
5454
***************

user_guide_src/source/dbmgmt/forge.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ change the name, you can add a "name" key into the field defining array.
297297
.. literalinclude:: forge/026.php
298298

299299
.. note:: The ``modifyColumn()`` may unexpectedly change ``NULL``/``NOT NULL``.
300-
So it is recommended to always specify ``null`` value. Unlike when creating
300+
So it is recommended to always specify the value for ``null`` key. Unlike when creating
301301
a table, if ``null`` is not specified, the column will be ``NULL``, not
302302
``NOT NULL``.
303303

user_guide_src/source/installation/upgrade_434.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ A bug fix may have changed the NULL constraint in the result of
3232
:ref:`$forge->modifyColumn() <db-forge-modifyColumn>`. See
3333
:ref:`Change Log <v434-forge-modifycolumn>`.
3434
To set the desired NULL constraint, change ``Forge::modifyColumn()`` to always
35-
specify the ``null`` value.
35+
specify the ``null`` key.
3636

3737
Note that the bug may have changed unexpected NULL constraints in previous
3838
versions.

0 commit comments

Comments
 (0)