Merge pull request #7157 from kenjis/fix-parser-local_currency

fix: [Parser] local_currency causes "Passing null to parameter"

Author: kenjis

system/View/Filters.php

@@ -171,6 +171,8 @@ public static function local_currency($value, string $currency, ?string $locale
     {
         helper('number');
 
+        $fraction ??= 0;
+
         $options = [
             'type'     => NumberFormatter::CURRENCY,
             'currency' => $currency,

tests/system/View/ParserFilterTest.php

@@ -396,6 +396,20 @@ public function testLocalCurrency()
         $this->assertSame("1.234.567,89\u{a0}€", $parser->renderString($template));
     }
 
+    public function testLocalCurrencyWithoutFraction()
+    {
+        $parser = new Parser($this->config, $this->viewsDir, $this->loader);
+
+        $data = [
+            'mynum' => 1_234_567.8912346,
+        ];
+
+        $template = '{ mynum|local_currency(EUR,de_DE) }';
+
+        $parser->setData($data);
+        $this->assertSame("1.234.568\u{a0}€", $parser->renderString($template));
+    }
+
     public function testParsePairWithAbs()
     {
         $parser = new Parser($this->config, $this->viewsDir, $this->loader);

user_guide_src/source/outgoing/view_parser.rst

@@ -389,8 +389,9 @@ limit_chars       limit            Limits the number of characters to $limit.
 
 limit_words       limit            Limits the number of words to $limit.                       { v|limit_words(20) }
 
-local_currency    currency, locale Displays a localized version of a currency. "currency"      { v|local_currency(EUR,en_US) }
-                                   valueis any 3-letter ISO 4217 currency code.
+local_currency    currency,        Displays a localized version of a currency. "currency"      { v|local_currency(EUR,en_US) }
+                  locale,          valueis any 3-letter ISO 4217 currency code.
+                  fraction
 
 local_number      type, precision, Displays a localized version of a number. "type" can be     { v|local_number(decimal,2,en_US) }
                   locale           one of: decimal, currency, percent, scientific, spellout,