fix: do not allow bool as $id

Author: kenjis

system/BaseModel.php

@@ -899,6 +899,10 @@ public function insertBatch(?array $set = null, ?bool $escape = null, int $batch
      */
     public function update($id = null, $data = null): bool
     {
+        if (is_bool($id)) {
+            throw new InvalidArgumentException('$id should not be boolean.');
+        }
+
         if (is_numeric($id) || is_string($id)) {
             $id = [$id];
         }
@@ -1037,6 +1041,10 @@ public function updateBatch(?array $set = null, ?string $index = null, int $batc
      */
     public function delete($id = null, bool $purge = false)
     {
+        if (is_bool($id)) {
+            throw new InvalidArgumentException('$id should not be boolean.');
+        }
+
         if ($id && (is_numeric($id) || is_string($id))) {
             $id = [$id];
         }

tests/system/Models/UpdateModelTest.php

@@ -15,6 +15,7 @@
 use CodeIgniter\Database\Exceptions\DataException;
 use CodeIgniter\Entity\Entity;
 use Generator;
+use InvalidArgumentException;
 use stdClass;
 use Tests\Support\Models\EventModel;
 use Tests\Support\Models\JobModel;
@@ -386,12 +387,10 @@ public function testUpdateWithSetAndEscape(): void
      *
      * @param false|null $id
      */
-    public function testUpdateThrowDatabaseExceptionWithoutWhereClause($id): void
+    public function testUpdateThrowDatabaseExceptionWithoutWhereClause($id, string $exception, string $exceptionMessage): void
     {
-        $this->expectException(DatabaseException::class);
-        $this->expectExceptionMessage(
-            'Updates are not allowed unless they contain a "where" or "like" clause.'
-        );
+        $this->expectException($exception);
+        $this->expectExceptionMessage($exceptionMessage);
 
         // $useSoftDeletes = false
         $this->createModel(JobModel::class);
@@ -402,8 +401,16 @@ public function testUpdateThrowDatabaseExceptionWithoutWhereClause($id): void
     public function provideInvalidIds(): Generator
     {
         yield from [
-            [null],
-            [false],
+            [
+                null,
+                DatabaseException::class,
+                'Updates are not allowed unless they contain a "where" or "like" clause.',
+            ],
+            [
+                false,
+                InvalidArgumentException::class,
+                '$id should not be boolean.',
+            ],
         ];
     }
 }