refactor: use properties

Author: kenjis

tests/system/Session/Handlers/Database/AbstractHandlerTestCase.php

@@ -11,6 +11,7 @@
 
 namespace CodeIgniter\Session\Handlers\Database;
 
+use CodeIgniter\Session\Handlers\DatabaseHandler;
 use CodeIgniter\Test\CIUnitTestCase;
 use CodeIgniter\Test\DatabaseTestTrait;
 use CodeIgniter\Test\ReflectionHelper;
@@ -25,8 +26,12 @@ abstract class AbstractHandlerTestCase extends CIUnitTestCase
     use DatabaseTestTrait;
     use ReflectionHelper;
 
-    protected $refresh = true;
-    protected $seed    = CITestSeeder::class;
+    protected $refresh                = true;
+    protected $seed                   = CITestSeeder::class;
+    protected string $sessionDriver   = DatabaseHandler::class;
+    protected string $sessionSavePath = 'ci_sessions';
+    protected string $sessionName     = 'ci_session';
+    protected string $userIpAddress   = '127.0.0.1';
 
     protected function setUp(): void
     {

tests/system/Session/Handlers/Database/MySQLiHandlerTest.php

@@ -12,7 +12,6 @@
 namespace CodeIgniter\Session\Handlers\Database;
 
 use CodeIgniter\Config\Factories;
-use CodeIgniter\Session\Handlers\DatabaseHandler;
 use Config\App as AppConfig;
 use Config\Database as DatabaseConfig;
 use Config\Session as SessionConfig;
@@ -36,10 +35,10 @@ protected function setUp(): void
     protected function getInstance($options = [])
     {
         $defaults = [
-            'driver'            => DatabaseHandler::class,
-            'cookieName'        => 'ci_session',
+            'driver'            => $this->sessionDriver,
+            'cookieName'        => $this->sessionName,
             'expiration'        => 7200,
-            'savePath'          => 'ci_sessions',
+            'savePath'          => $this->sessionSavePath,
             'matchIP'           => false,
             'timeToUpdate'      => 300,
             'regenerateDestroy' => false,
@@ -52,6 +51,6 @@ protected function getInstance($options = [])
         }
         Factories::injectMock('config', 'Session', $sessionConfig);
 
-        return new MySQLiHandler(new AppConfig(), '127.0.0.1');
+        return new MySQLiHandler(new AppConfig(), $this->userIpAddress);
     }
 }

tests/system/Session/Handlers/Database/PostgreHandlerTest.php

@@ -12,7 +12,6 @@
 namespace CodeIgniter\Session\Handlers\Database;
 
 use CodeIgniter\Config\Factories;
-use CodeIgniter\Session\Handlers\DatabaseHandler;
 use Config\App as AppConfig;
 use Config\Database as DatabaseConfig;
 use Config\Session as SessionConfig;
@@ -36,10 +35,10 @@ protected function setUp(): void
     protected function getInstance($options = [])
     {
         $defaults = [
-            'driver'            => DatabaseHandler::class,
-            'cookieName'        => 'ci_session',
+            'driver'            => $this->sessionDriver,
+            'cookieName'        => $this->sessionName,
             'expiration'        => 7200,
-            'savePath'          => 'ci_sessions',
+            'savePath'          => $this->sessionSavePath,
             'matchIP'           => false,
             'timeToUpdate'      => 300,
             'regenerateDestroy' => false,
@@ -52,6 +51,6 @@ protected function getInstance($options = [])
         }
         Factories::injectMock('config', 'Session', $sessionConfig);
 
-        return new PostgreHandler(new AppConfig(), '127.0.0.1');
+        return new PostgreHandler(new AppConfig(), $this->userIpAddress);
     }
 }

tests/system/Session/Handlers/Database/RedisHandlerTest.php

@@ -27,14 +27,15 @@
  */
 final class RedisHandlerTest extends CIUnitTestCase
 {
+    private string $sessionDriver   = RedisHandler::class;
     private string $sessionName     = 'ci_session';
     private string $sessionSavePath = 'tcp://127.0.0.1:6379';
     private string $userIpAddress   = '127.0.0.1';
 
     protected function getInstance($options = [])
     {
         $defaults = [
-            'driver'            => RedisHandler::class,
+            'driver'            => $this->sessionDriver,
             'cookieName'        => $this->sessionName,
             'expiration'        => 7200,
             'savePath'          => $this->sessionSavePath,