Merge pull request #5854 from kenjis/fix-docs-replace-echo-with-return

docs: replace `echo` with `return`

Author: kenjis

user_guide_src/source/cli/cli/001.php

@@ -8,6 +8,6 @@ class Tools extends Controller
 {
     public function message($to = 'World')
     {
-        echo "Hello {$to}!" . PHP_EOL;
+        return "Hello {$to}!" . PHP_EOL;
     }
 }

user_guide_src/source/incoming/controllers/008.php

@@ -6,6 +6,6 @@ class Helloworld extends BaseController
 {
     public function index()
     {
-        echo 'Hello World!';
+        return 'Hello World!';
     }
 }

user_guide_src/source/incoming/controllers/013.php

@@ -6,11 +6,11 @@ class Helloworld extends BaseController
 {
     public function index()
     {
-        echo 'Hello World!';
+        return 'Hello World!';
     }
 
     public function comment()
     {
-        echo 'I am not flat!';
+        return 'I am not flat!';
     }
 }

user_guide_src/source/incoming/controllers/014.php

@@ -6,7 +6,7 @@ class Products extends BaseController
 {
     public function shoes($sandals, $id)
     {
-        echo $sandals;
-        echo $id;
+        return $sandals
+            . $id;
     }
 }

user_guide_src/source/installation/upgrade_controllers/001.php

@@ -6,6 +6,6 @@ class Helloworld extends BaseController
 {
     public function index($name)
     {
-        echo 'Hello ' . esc($name) . '!';
+        return 'Hello ' . esc($name) . '!';
     }
 }

user_guide_src/source/installation/upgrade_file_upload/001.php

@@ -6,7 +6,7 @@ class Upload extends BaseController
 {
     public function index()
     {
-        echo view('upload_form', ['error' => ' ']);
+        return view('upload_form', ['error' => ' ']);
     }
 
     public function do_upload()
@@ -20,11 +20,10 @@ public function do_upload()
         $file = $this->request->getFile('userfile');
 
         if (! $path = $file->store()) {
-            echo view('upload_form', ['error' => 'upload failed']);
-        } else {
-            $data = ['upload_file_path' => $path];
-
-            echo view('upload_success', $data);
+            return view('upload_form', ['error' => 'upload failed']);
         }
+        $data = ['upload_file_path' => $path];
+
+        return view('upload_success', $data);
     }
 }

user_guide_src/source/installation/upgrade_pagination/001.php

@@ -7,4 +7,4 @@
     'pager' => $model->pager,
 ];
 
-echo view('users/index', $data);
+return view('users/index', $data);

user_guide_src/source/installation/upgrade_view_parser.rst

@@ -19,7 +19,7 @@ What has been changed
 Upgrade Guide
 =============
 1. Wherever you use the View Parser Library replace ``$this->load->library('parser');`` with ``$parser = service('parser');``.
-2. You have to change the render part in your controller from ``$this->parser->parse('blog_template', $data);`` to ``echo $parser->setData($data)->render('blog_template');``.
+2. You have to change the render part in your controller from ``$this->parser->parse('blog_template', $data);`` to ``return $parser->setData($data)->render('blog_template');``.
 
 Code Example
 ============

user_guide_src/source/installation/upgrade_view_parser/001.php

@@ -7,4 +7,4 @@
     'blog_heading' => 'My Blog Heading',
 ];
 
-echo $parser->setData($data)->render('blog_template');
+return $parser->setData($data)->render('blog_template');

user_guide_src/source/installation/upgrade_views.rst

@@ -15,7 +15,7 @@ What has been changed
 =====================
 
 - Your views look much like before, but they are invoked differently ... instead of CI3's
-  ``$this->load->view(x);``, you can use ``echo view(x);``.
+  ``$this->load->view(x);``, you can use ``return view(x);``.
 - CI4 supports *View Cells* to build your response in pieces, and *View Layouts* for page layout.
 - The template parser is still there, and substantially enhanced.
 
@@ -24,7 +24,7 @@ Upgrade Guide
 
 1. First, move all views  to the folder **app/Views**
 2. Change the loading syntax of views in every script where you load views:
-    - from ``$this->load->view('directory_name/file_name')`` to ``echo view('directory_name/file_name');``
+    - from ``$this->load->view('directory_name/file_name')`` to ``return view('directory_name/file_name');``
     - from ``$content = $this->load->view('file', $data, TRUE);`` to ``$content = view('file', $data);``
 3. (optional) You can change the echo syntax in views from ``<?php echo $title; ?>`` to ``<?= $title ?>``