refactor: Apply PHPStan rule to RouteCollection::loadRoutesOptions()

pjsde · pjsde · commit 26c403524437 · 2023-09-16T12:28:04.000+01:00
diff --git a/system/Router/RouteCollection.php b/system/Router/RouteCollection.php
@@ -1700,7 +1700,9 @@ public function resetRoutes()
      */
     protected function loadRoutesOptions(?string $verb = null): array
     {
-        $verb = $verb ?: $this->getHTTPVerb();
+        if (null === $verb || $verb === '') {
+            $verb = $this->getHTTPVerb();
+        }
 
         $options = $this->routesOptions[$verb] ?? [];
 

Original file line number	Diff line number	Diff line change
`@@ -1700,7 +1700,9 @@ public function resetRoutes()`
`1700`	`1700`	`*/`
`1701`	`1701`	`protected function loadRoutesOptions(?string $verb = null): array`
`1702`	`1702`	`{`
`1703`		`- $verb = $verb ?: $this->getHTTPVerb();`
	`1703`	`+ if (null === $verb \|\| $verb === '') {`
	`1704`	`+ $verb = $this->getHTTPVerb();`
	`1705`	`+ }`
`1704`	`1706`
`1705`	`1707`	`$options = $this->routesOptions[$verb] ?? [];`
`1706`	`1708`