Skip to content

Commit 1e3d73a

Browse files
committed
Change to getFieldNames()
If query returns no rows then I wouldn't get field names. this way I do.
1 parent a345821 commit 1e3d73a

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

system/Database/BaseBuilder.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2128,9 +2128,9 @@ public function fromQuery($query, $columns = null): BaseBuilder
21282128
*/
21292129
protected function fieldsFromQuery(string $sql): array
21302130
{
2131-
$query = $this->db->query('SELECT * FROM (' . $sql . ') _u_ LIMIT 1')->getResultArray();
2131+
$fields = $this->db->query('SELECT * FROM (' . $sql . ') _u_ LIMIT 1')->getFieldNames();
21322132

2133-
return array_keys(current($query));
2133+
return $fields;
21342134
}
21352135

21362136
/**

system/Database/OCI8/Builder.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -519,8 +519,8 @@ protected function _deleteBatch(string $table, array $keys, array $values): stri
519519
*/
520520
protected function fieldsFromQuery(string $sql): array
521521
{
522-
$query = $this->db->query('SELECT * FROM (' . $sql . ') "_u_" WHERE ROWNUM = 1')->getResultArray();
522+
$fields = $this->db->query('SELECT * FROM (' . $sql . ') "_u_" WHERE ROWNUM = 1')->getFieldNames();
523523

524-
return array_keys(current($query));
524+
return $fields;
525525
}
526526
}

system/Database/SQLSRV/Builder.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -770,8 +770,8 @@ protected function _upsertBatch(string $table, array $keys, array $values): stri
770770
*/
771771
protected function fieldsFromQuery(string $sql): array
772772
{
773-
$query = $this->db->query('SELECT TOP 1 * FROM (' . $sql . ') _u_')->getResultArray();
773+
$fields = $this->db->query('SELECT TOP 1 * FROM (' . $sql . ') _u_')->getFieldNames();
774774

775-
return array_keys(current($query));
775+
return $fields;
776776
}
777777
}

0 commit comments

Comments
 (0)