fix: do not create dynamic property in BaseConnection

kenjis · kenjis · commit 186b7efbb7bc · 2022-06-29T10:06:11.000+09:00
diff --git a/system/Database/BaseConnection.php b/system/Database/BaseConnection.php
@@ -336,7 +336,9 @@ abstract class BaseConnection implements ConnectionInterface
     public function __construct(array $params)
     {
         foreach ($params as $key => $value) {
-            $this->{$key} = $value;
+            if (property_exists($this, $key)) {
+                $this->{$key} = $value;
+            }
         }
 
         $queryClass = str_replace('Connection', 'Query', static::class);

Original file line number	Diff line number	Diff line change
`@@ -336,7 +336,9 @@ abstract class BaseConnection implements ConnectionInterface`
`336`	`336`	`public function __construct(array $params)`
`337`	`337`	`{`
`338`	`338`	`foreach ($params as $key => $value) {`
`339`		`- $this->{$key} = $value;`
	`339`	`+ if (property_exists($this, $key)) {`
	`340`	`+ $this->{$key} = $value;`
	`341`	`+ }`
`340`	`342`	`}`
`341`	`343`
`342`	`344`	`$queryClass = str_replace('Connection', 'Query', static::class);`