Skip to content

Commit 18138fa

Browse files
committed
fix: remove unserialize() in old()
I can't think of any use cases.
1 parent 76ad2ad commit 18138fa

2 files changed

Lines changed: 1 addition & 6 deletions

File tree

system/Common.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -813,11 +813,6 @@ function old(string $key, $default = null, $escape = 'html')
813813
return $default;
814814
}
815815

816-
// If the result was serialized array or string, then unserialize it for use...
817-
if (is_string($value) && (strpos($value, 'a:') === 0 || strpos($value, 's:') === 0)) {
818-
$value = unserialize($value);
819-
}
820-
821816
return $escape === false ? $value : esc($value, $escape);
822817
}
823818
}

tests/system/CommonFunctionsTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ public function testOldInput()
300300
$_GET = ['foo' => 'bar'];
301301
$_POST = [
302302
'bar' => 'baz',
303-
'zibble' => serialize('fritz'),
303+
'zibble' => 'fritz',
304304
];
305305

306306
$response = new RedirectResponse(new App());

0 commit comments

Comments
 (0)