Skip to content

Commit 13d8246

Browse files
authored
Merge pull request #6998 from kenjis/fix-services-session
fix: Config\Session
2 parents feb1772 + 503ab4f commit 13d8246

2 files changed

Lines changed: 8 additions & 4 deletions

File tree

app/Config/Session.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
namespace Config;
44

55
use CodeIgniter\Config\BaseConfig;
6+
use CodeIgniter\Session\Handlers\BaseHandler;
67
use CodeIgniter\Session\Handlers\FileHandler;
7-
use SessionHandlerInterface;
88

99
class Session extends BaseConfig
1010
{
@@ -19,7 +19,7 @@ class Session extends BaseConfig
1919
* - `CodeIgniter\Session\Handlers\MemcachedHandler`
2020
* - `CodeIgniter\Session\Handlers\RedisHandler`
2121
*
22-
* @phpstan-var class-string<SessionHandlerInterface>
22+
* @phpstan-var class-string<BaseHandler>
2323
*/
2424
public string $driver = FileHandler::class;
2525

system/Config/Services.php

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@
7373
use Config\Migrations;
7474
use Config\Pager as PagerConfig;
7575
use Config\Services as AppServices;
76+
use Config\Session as SessionConfig;
7677
use Config\Toolbar as ToolbarConfig;
7778
use Config\Validation as ValidationConfig;
7879
use Config\View as ViewConfig;
@@ -645,10 +646,13 @@ public static function session(?App $config = null, bool $getShared = true)
645646

646647
$logger = AppServices::logger();
647648

648-
$driverName = $config->sessionDriver;
649+
/** @var SessionConfig|null $sessionConfig */
650+
$sessionConfig = config('Session');
651+
652+
$driverName = $sessionConfig->driver ?? $config->sessionDriver;
649653

650654
if ($driverName === DatabaseHandler::class) {
651-
$DBGroup = $config->sessionDBGroup ?? config(Database::class)->defaultGroup;
655+
$DBGroup = $sessionConfig->DBGroup ?? $config->sessionDBGroup ?? config(Database::class)->defaultGroup;
652656
$db = Database::connect($DBGroup);
653657

654658
$driver = $db->getPlatform();

0 commit comments

Comments
 (0)