re-run rector with enable RemoveAlwaysTrueIfConditionRector with skip only in trait

Author: samsonasik

phpstan-baseline.neon.dist

@@ -70,11 +70,6 @@ parameters:
 			count: 1
 			path: system/Cache/Handlers/MemcachedHandler.php
 
-		-
-			message: "#^Variable \\$config in empty\\(\\) always exists and is not falsy\\.$#"
-			count: 1
-			path: system/Cache/Handlers/MemcachedHandler.php
-
 		-
 			message: "#^Variable \\$data might not be defined\\.$#"
 			count: 1
@@ -90,11 +85,6 @@ parameters:
 			count: 1
 			path: system/Cache/Handlers/RedisHandler.php
 
-		-
-			message: "#^Variable \\$config in empty\\(\\) always exists and is not falsy\\.$#"
-			count: 1
-			path: system/Cache/Handlers/RedisHandler.php
-
 		-
 			message: "#^Call to an undefined method CodeIgniter\\\\HTTP\\\\Request\\:\\:getPost\\(\\)\\.$#"
 			count: 1

rector.php

@@ -131,8 +131,11 @@
             __DIR__ . '/tests/system/Email/EmailTest.php',
         ],
 
-        // buggy on read based on @var on property
-        RemoveAlwaysTrueIfConditionRector::class,
+        // buggy on read based on @var on property on Trait
+        RemoveAlwaysTrueIfConditionRector::class => [
+            '**Trait.php',
+            __DIR__ . '/system/Test/ControllerTester.php',
+        ],
     ]);
 
     // auto import fully qualified class names

system/Autoloader/Autoloader.php

@@ -141,9 +141,7 @@ public function register()
 
         // Load our non-class files
         foreach ($this->files as $file) {
-            if (is_string($file)) {
-                $this->includeFile($file);
-            }
+            $this->includeFile($file);
         }
     }
 

system/Cache/Handlers/MemcachedHandler.php

@@ -45,9 +45,7 @@ public function __construct(Cache $config)
     {
         $this->prefix = $config->prefix;
 
-        if (! empty($config)) {
-            $this->config = array_merge($this->config, $config->memcached);
-        }
+        $this->config = array_merge($this->config, $config->memcached);
     }
 
     /**

system/Cache/Handlers/RedisHandler.php

@@ -45,9 +45,7 @@ public function __construct(Cache $config)
     {
         $this->prefix = $config->prefix;
 
-        if (! empty($config)) {
-            $this->config = array_merge($this->config, $config->redis);
-        }
+        $this->config = array_merge($this->config, $config->redis);
     }
 
     /**

system/Database/Forge.php

@@ -764,11 +764,9 @@ public function modifyColumn(string $table, $field): bool
             return false;
         }
 
-        if ($sqls !== null) {
-            foreach ($sqls as $sql) {
-                if ($this->db->query($sql) === false) {
-                    return false;
-                }
+        foreach ($sqls as $sql) {
+            if ($this->db->query($sql) === false) {
+                return false;
             }
         }
 

system/Helpers/form_helper.php

@@ -63,10 +63,8 @@ function form_open(string $action = '', $attributes = [], array $hidden = []): s
             $form .= csrf_field($csrfId ?? null);
         }
 
-        if (is_array($hidden)) {
-            foreach ($hidden as $name => $value) {
-                $form .= form_hidden($name, $value);
-            }
+        foreach ($hidden as $name => $value) {
+            $form .= form_hidden($name, $value);
         }
 
         return $form;