Merge pull request #4161 from paulbalandan/db-create-fix-memory

Fix strict checking for SQLite3 memory filename

Author: michalsn

system/Commands/Database/CreateDatabase.php

@@ -102,15 +102,15 @@ public function run(array $params)
 					$ext = CLI::prompt('Please choose a valid file extension', ['db', 'sqlite']); // @codeCoverageIgnore
 				}
 
-				if (strpos($name, ':memory:') === false)
+				if ($name !== ':memory:')
 				{
 					$name = str_replace(['.db', '.sqlite'], '', $name) . ".{$ext}";
 				}
 
 				$config->{$group}['DBDriver'] = 'SQLite3';
 				$config->{$group}['database'] = $name;
 
-				if (strpos($name, ':memory:') === false)
+				if ($name !== ':memory:')
 				{
 					$dbName = strpos($name, DIRECTORY_SEPARATOR) === false ? WRITEPATH . $name : $name;
 
@@ -131,7 +131,7 @@ public function run(array $params)
 				$db->connect();
 				Factories::reset('config');
 
-				if (! is_file($db->getDatabase()) && strpos($name, ':memory:') === false)
+				if (! is_file($db->getDatabase()) && $name !== ':memory:')
 				{
 					// @codeCoverageIgnoreStart
 					CLI::error('Database creation failed.', 'light_gray', 'red');