refactor: add assert() for clarity

kenjis · kenjis · commit 00dc9fdc21c1 · 2022-10-23T13:27:06.000+09:00
diff --git a/system/Database/Config.php b/system/Database/Config.php
@@ -62,6 +62,8 @@ public static function connect($group = null, bool $getShared = true)
                 $group = (ENVIRONMENT === 'testing') ? 'tests' : $dbConfig->defaultGroup;
             }
 
+            assert(is_string($group));
+
             if (! isset($dbConfig->{$group})) {
                 throw new InvalidArgumentException($group . ' is not a valid database connection group.');
             }

Original file line number	Diff line number	Diff line change
`@@ -62,6 +62,8 @@ public static function connect($group = null, bool $getShared = true)`
`62`	`62`	`$group = (ENVIRONMENT === 'testing') ? 'tests' : $dbConfig->defaultGroup;`
`63`	`63`	`}`
`64`	`64`
	`65`	`+ assert(is_string($group));`
	`66`	`+`
`65`	`67`	`if (! isset($dbConfig->{$group})) {`
`66`	`68`	`throw new InvalidArgumentException($group . ' is not a valid database connection group.');`
`67`	`69`	`}`