Skip to content

Commit 12eb140

Browse files
Fix for #48
1 parent 1265036 commit 12eb140

3 files changed

Lines changed: 24 additions & 16 deletions

File tree

app/src/main/java/org/open311/android/MainActivity.java

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,21 @@ public boolean onCreateOptionsMenu(Menu menu) {
9090
final List<Server> servers = new Servers().getCollection();
9191
getMenuInflater().inflate(R.menu.main, menu);
9292
MenuItem mapItem = menu.findItem(R.id.setting_map);
93+
if (currentServer.getMap() == null || currentServer.getMap().getRequestMapEnabled()) {
94+
mapItem.setVisible(true);
95+
mapItem.setOnMenuItemClickListener(new MenuItem.OnMenuItemClickListener() {
96+
@Override
97+
public boolean onMenuItemClick(MenuItem menuItem) {
98+
//Show the map
99+
Intent intent = new Intent(MainActivity.this, MapActivity.class);
100+
startActivityForResult(intent, LOCATION_REQUEST);
101+
return false;
102+
}
103+
});
104+
} else {
105+
mapItem.setVisible(false);
106+
}
107+
93108
MenuItem serverItem = menu.findItem(R.id.setting_general);
94109
serverItem.setOnMenuItemClickListener(new MenuItem.OnMenuItemClickListener() {
95110
@Override
@@ -141,15 +156,7 @@ public void onClick(DialogInterface dialog, int id) {
141156
return false;
142157
}
143158
});
144-
mapItem.setOnMenuItemClickListener(new MenuItem.OnMenuItemClickListener() {
145-
@Override
146-
public boolean onMenuItemClick(MenuItem menuItem) {
147-
//Show the map
148-
Intent intent = new Intent(MainActivity.this, MapActivity.class);
149-
startActivityForResult(intent, LOCATION_REQUEST);
150-
return false;
151-
}
152-
});
159+
153160
return true;
154161
}
155162

app/src/main/res/menu/main.xml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,16 @@
22
<menu xmlns:android="http://schemas.android.com/apk/res/android"
33
xmlns:app="http://schemas.android.com/apk/res-auto">
44
<item
5-
android:id="@+id/setting_general"
5+
android:id="@+id/setting_map"
6+
android:icon="@drawable/ic_map_white"
67
android:orderInCategory="1"
7-
android:icon="@drawable/ic_settings_white"
8-
android:title="@string/setting_general"
8+
android:title="@string/setting_map"
99
app:showAsAction="ifRoom" />
1010
<item
11-
android:id="@+id/setting_map"
11+
android:id="@+id/setting_general"
12+
android:icon="@drawable/ic_settings_white"
1213
android:orderInCategory="2"
13-
android:icon="@drawable/ic_map_white"
14-
android:title="@string/setting_map"
14+
android:title="@string/setting_general"
1515
app:showAsAction="ifRoom" />
16+
1617
</menu>

org.codeforamerica.open311

0 commit comments

Comments
 (0)