fix: replace broken chosen-rails gem with official Chosen v1.8.7 assets

## Problem

The chosen-rails gem's support-rails-8 branch has broken CoffeeScript
compilation that causes Chosen dropdowns to appear empty despite having
populated <option> elements in the DOM.

The CoffeeScript comprehension syntax was compiling to broken JavaScript
with uninitialized loop variables (`for (undefined; i < len; i++)`),
causing loops to never execute. This affected both option parsing and
DOM rendering.

## Root Cause

CoffeeScript 1.12.2 (from 2016) combined with the support-rails-8
branch produces incorrect JavaScript compilation for comprehension loops.

## Solution

Removed the chosen-rails gem dependency and replaced it with official
pre-compiled Chosen v1.8.7 assets in vendor/:

- vendor/assets/javascripts/chosen.jquery.js
- vendor/assets/stylesheets/chosen.css
- vendor/assets/images/chosen-sprite.png
- vendor/assets/images/chosen-sprite@2x.png

Updated application.js to require chosen.jquery from vendor instead of
the gem.

## Benefits

1. Avoids CoffeeScript compilation issues entirely
2. Removes unnecessary gem dependency
3. Full control over Chosen version
4. Simpler asset pipeline (no gem-based asset resolution)

## Additional Fixes

- Fixed JavaScript syntax error in application.js (chosen() options)
- Fixed script loading order (jQuery before Bootstrap)
- Added blank prompt option to members dropdown

## Testing

Verified working:
- Member directory dropdown (240 members)
- Search/filter functionality
- Keyboard navigation
- Single deselect option

## Future Consideration

This uses the jQuery-dependent Chosen library. Long-term, consider
replacing with a modern JavaScript alternative without jQuery dependency.

Author: mroderick

Gemfile

@@ -51,7 +51,8 @@ gem 'pagy', '~> 43.2'
 gem 'icalendar'
 gem 'tzinfo-data'
 
-gem 'chosen-rails', github: 'olleolleolle/chosen-rails', branch: 'support-rails-8'
+# Chosen JavaScript and CSS loaded from vendor/assets/ instead of gem
+# The chosen-rails gem has broken CoffeeScript compilation on Rails 8.1
 gem 'commonmarker'
 
 gem 'faraday'

Gemfile.lock

@@ -6,16 +6,6 @@ GIT
     sitemap_generator (6.3.0)
       builder (~> 3.0)
 
-GIT
-  remote: https://github.com/olleolleolle/chosen-rails.git
-  revision: cfef31cb30ed6d0dfd65cae0ff6f4a2943812df0
-  branch: support-rails-8
-  specs:
-    chosen-rails (2.0.0)
-      coffee-rails (>= 3.2)
-      dartsass-rails (>= 0.5.0)
-      railties (>= 3.0)
-
 GEM
   remote: https://rubygems.org/
   specs:
@@ -164,13 +154,6 @@ GEM
       logger (~> 1.5)
     cocoon (1.2.15)
     coderay (1.1.3)
-    coffee-rails (5.0.0)
-      coffee-script (>= 2.2.0)
-      railties (>= 5.2.0)
-    coffee-script (2.4.1)
-      coffee-script-source
-      execjs
-    coffee-script-source (1.12.2)
     commonmarker (2.6.3-aarch64-linux)
     commonmarker (2.6.3-arm64-darwin)
     commonmarker (2.6.3-x86_64-darwin)
@@ -184,9 +167,6 @@ GEM
     css_parser (1.14.0)
       addressable
     csv (3.3.5)
-    dartsass-rails (0.5.1)
-      railties (>= 6.0.0)
-      sass-embedded (~> 1.63)
     database_cleaner (2.1.0)
       database_cleaner-active_record (>= 2, < 3)
     database_cleaner-active_record (2.2.2)
@@ -234,18 +214,6 @@ GEM
       activerecord (>= 4.0.0)
     globalid (1.3.0)
       activesupport (>= 6.1)
-    google-protobuf (4.33.2-aarch64-linux-gnu)
-      bigdecimal
-      rake (>= 13)
-    google-protobuf (4.33.2-arm64-darwin)
-      bigdecimal
-      rake (>= 13)
-    google-protobuf (4.33.2-x86_64-darwin)
-      bigdecimal
-      rake (>= 13)
-    google-protobuf (4.33.2-x86_64-linux-gnu)
-      bigdecimal
-      rake (>= 13)
     haml (7.2.0)
       temple (>= 0.8.2)
       thor
@@ -548,14 +516,6 @@ GEM
     ruby-vips (2.3.0)
       ffi (~> 1.12)
       logger
-    sass-embedded (1.97.0-aarch64-linux-gnu)
-      google-protobuf (~> 4.31)
-    sass-embedded (1.97.0-arm64-darwin)
-      google-protobuf (~> 4.31)
-    sass-embedded (1.97.0-x86_64-darwin)
-      google-protobuf (~> 4.31)
-    sass-embedded (1.97.0-x86_64-linux-gnu)
-      google-protobuf (~> 4.31)
     sassc (2.4.0)
       ffi (~> 1.9)
     sassc-rails (2.1.2)
@@ -659,7 +619,6 @@ DEPENDENCIES
   capybara-playwright-driver
   carrierwave
   carrierwave-aws (~> 1.6)
-  chosen-rails!
   cocoon
   commonmarker
   csv

app/assets/javascripts/application.js

@@ -10,14 +10,14 @@
 // Read Sprockets README (https://github.com/sstephenson/sprockets#sprockets-directives) for details
 // about supported directives.
 //
+//= require jquery
 //= require popper
 //= require bootstrap
-//= require jquery
 //= require rails-ujs
 //= require activestorage
 //= require jquery-ui
 //= require autocomplete-rails
-//= require chosen-jquery
+//= require chosen.jquery
 //= require 'jsimple-star-rating.min.js'
 //= require pickadate/picker
 //= require pickadate/picker.date
@@ -59,12 +59,12 @@ $(function() {
     }).show();
   });
 
-  $('select').chosen(function(){
-    allow_single_deselect: true
+  $('select').chosen({
+    allow_single_deselect: true,
     no_results_text: 'No results matched'
   });
 
-  $('#member_lookup_id').chosen().change(function(e) {
+  $('#member_lookup_id').change(function(e) {
     $('#view_profile').attr('href', '/admin/members/' + $(this).val())
   });
 

app/views/admin/members/index.html.haml

@@ -4,7 +4,7 @@
       %h1 Members Directory
   .row.mb-4
     .col-12.col-md-6
-      = select_tag 'member_lookup_id', options_for_select(@members.collect{ |u| ["#{u.full_name} (#{u.email})", u.id] }), { class: 'chosen-select' }
+      = select_tag 'member_lookup_id', options_for_select([['Select a member...', '']] + @members.collect{ |u| ["#{u.full_name} (#{u.email})", u.id] }), { class: 'chosen-select' }
   .row
     .col
       = link_to 'View Profile', '#', { class: 'btn btn-primary', id: 'view_profile' }