feat(admin): migrate member search to params.expect

- Convert index action to use conditional params.expect for optional member_search
- Convert results action to use params.expect with nested array syntax
- Add test coverage for results action
- Handles optional parameters gracefully with conditional check

Author: mroderick

app/controllers/admin/member_search_controller.rb

@@ -1,9 +1,15 @@
 class Admin::MemberSearchController < Admin::ApplicationController
   def index
-    member_params = params[:member_search] || {}
-    name = member_params[:name]
+    search_params = if params.key?(:member_search)
+                      params.expect(member_search: [:name, :callback_url])
+                    else
+                      {}
+                    end
+
+    callback_url = search_params[:callback_url] || params[:callback_url] || results_admin_member_search_index_path
+    name = search_params[:name]
     members = name.blank? ? Member.none : Member.find_members_by_name(name).select(:id, :name, :surname, :pronouns)
-    callback_url = member_params[:callback_url] || params[:callback_url] || results_admin_member_search_index_path
+
     if members.size == 1
       query = { member_pick: { members: [members.first.id] } }
       query_string = query.to_query
@@ -15,7 +21,8 @@ def index
   end
 
   def results
-    members = Member.find(params[:member_pick][:members])
+    pick_params = params.expect(member_pick: { members: [] })
+    members = Member.find(pick_params[:members])
     render 'show', locals: { members: members }
   end
 end

spec/controllers/admin/member_search_controller_spec.rb

@@ -53,4 +53,20 @@
       end
     end
   end
+
+  describe 'GET #results' do
+    context 'when user is an admin' do
+      let(:member1) { Fabricate(:member, name: 'Alice') }
+      let(:member2) { Fabricate(:member, name: 'Bob') }
+
+      before do
+        login_as_admin(member)
+      end
+
+      it 'finds members by ids using params.expect' do
+        get :results, params: { member_pick: { members: [member1.id, member2.id] } }
+        expect(response).to have_http_status(:ok)
+      end
+    end
+  end
 end