code cleanup

Author: tstromberg

cmd/review-goose/icons_badge.go

@@ -55,7 +55,7 @@ func getIcon(iconType IconType, counts PRCounts) []byte {
 	}
 
 	// Check cache
-	if cached, ok := cache.Get(incoming, outgoing); ok {
+	if cached, ok := cache.Lookup(incoming, outgoing); ok {
 		return cached
 	}
 

cmd/review-goose/main.go

@@ -764,7 +764,7 @@ func (app *App) updatePRs(ctx context.Context) {
 
 	// Process notifications using the simplified state manager
 	slog.Debug("[DEBUG] Processing PR state updates and notifications")
-	app.updatePRStatesAndNotify(ctx)
+	app.processNotifications(ctx)
 	slog.Debug("[DEBUG] Completed PR state updates and notifications")
 }
 
@@ -927,7 +927,7 @@ func (app *App) updatePRsWithWait(ctx context.Context) {
 
 	// Process notifications using the simplified state manager
 	slog.Info("[FLOW] About to process PR state updates and notifications")
-	app.updatePRStatesAndNotify(ctx)
+	app.processNotifications(ctx)
 	slog.Info("[FLOW] Completed PR state updates and notifications")
 	// Mark initial load as complete after first successful update
 	if !app.initialLoadComplete {
@@ -998,9 +998,7 @@ func (app *App) tryAutoOpenPR(ctx context.Context, pr *PR, autoBrowserEnabled bo
 	}
 }
 
-// checkForNewlyBlockedPRs provides backward compatibility for tests
-// while using the new state manager internally.
+// checkForNewlyBlockedPRs provides backward compatibility for tests.
 func (app *App) checkForNewlyBlockedPRs(ctx context.Context) {
-	// Simply delegate to the new implementation
-	app.updatePRStatesAndNotify(ctx)
+	app.processNotifications(ctx)
 }

cmd/review-goose/notifications.go

@@ -116,9 +116,3 @@ func (app *App) sendPRNotification(ctx context.Context, pr *PR, title string, so
 		*playedSound = true
 	}
 }
-
-// updatePRStatesAndNotify is the simplified replacement for checkForNewlyBlockedPRs.
-func (app *App) updatePRStatesAndNotify(ctx context.Context) {
-	// Simple and clear: just process notifications
-	app.processNotifications(ctx)
-}

cmd/review-goose/ratelimit.go

@@ -144,7 +144,7 @@ func (hm *healthMonitor) recordCacheAccess(hit bool) {
 	}
 }
 
-func (hm *healthMonitor) getMetrics() map[string]any {
+func (hm *healthMonitor) metrics() map[string]any {
 	hm.mu.RLock()
 	defer hm.mu.RUnlock()
 
@@ -172,7 +172,7 @@ func (hm *healthMonitor) getMetrics() map[string]any {
 }
 
 func (hm *healthMonitor) logMetrics() {
-	metrics := hm.getMetrics()
+	m := hm.metrics()
 
 	// Get sprinkler connection status
 	sprinklerConnected := false
@@ -186,11 +186,11 @@ func (hm *healthMonitor) logMetrics() {
 	}
 
 	slog.Info("[HEALTH] Application metrics",
-		"uptime", metrics["uptime"],
-		"api_calls", metrics["api_calls"],
-		"api_errors", metrics["api_errors"],
-		"error_rate_pct", fmt.Sprintf("%.1f", metrics["error_rate"]),
-		"cache_hit_rate_pct", fmt.Sprintf("%.1f", metrics["cache_hit_rate"]),
+		"uptime", m["uptime"],
+		"api_calls", m["api_calls"],
+		"api_errors", m["api_errors"],
+		"error_rate_pct", fmt.Sprintf("%.1f", m["error_rate"]),
+		"cache_hit_rate_pct", fmt.Sprintf("%.1f", m["cache_hit_rate"]),
 		"sprinkler_connected", sprinklerConnected,
 		"sprinkler_last_connected", sprinklerLastConnected)
 }

cmd/review-goose/reliability.go

@@ -282,7 +282,14 @@ func (sm *sprinklerMonitor) processEvents(ctx context.Context) {
 func (sm *sprinklerMonitor) checkAndNotify(ctx context.Context, evt prEvent) {
 	start := time.Now()
 
-	user := sm.currentUser()
+	// Determine user: targetUser takes precedence over currentUser
+	user := ""
+	if sm.app.currentUser != nil {
+		user = sm.app.currentUser.GetLogin()
+	}
+	if sm.app.targetUser != "" {
+		user = sm.app.targetUser
+	}
 	if user == "" {
 		slog.Debug("[SPRINKLER] Skipping check - no user configured", "url", evt.url)
 		return
@@ -327,18 +334,6 @@ func (sm *sprinklerMonitor) checkAndNotify(ctx context.Context, evt prEvent) {
 	sm.sendNotifications(ctx, evt.url, repo, n, act)
 }
 
-// currentUser returns the configured user for the sprinkler monitor.
-func (sm *sprinklerMonitor) currentUser() string {
-	user := ""
-	if sm.app.currentUser != nil {
-		user = sm.app.currentUser.GetLogin()
-	}
-	if sm.app.targetUser != "" {
-		user = sm.app.targetUser
-	}
-	return user
-}
-
 // fetchTurnData retrieves PR data from Turn API with retry logic.
 func (sm *sprinklerMonitor) fetchTurnData(ctx context.Context, evt prEvent, repo string, n int, start time.Time) (*turn.CheckResponse, bool) {
 	var data *turn.CheckResponse