[zapx] Fixed longestCommonPrefOffset() +tests

Author: asp24

internal/zapx/slowlog_enc.go

@@ -44,25 +44,25 @@ func (sle *SlowlogEncoder) addDir(p string) bool {
 	return true
 }
 
-func (sle *SlowlogEncoder) longestCommonPrefOffset() int {
-	if len(sle.strBuf) <= 0 {
+func (sle *SlowlogEncoder) longestCommonPrefOffset(ss []string) int {
+	if len(ss) <= 0 {
 		return 0
 	}
 
-	if len(sle.strBuf) == 1 {
-		return len(sle.strBuf[0]) + 1
+	if len(ss) == 1 {
+		return len(ss[0])
 	}
 
-	first := sle.strBuf[0]
-	last := sle.strBuf[len(sle.strBuf)-1]
+	first := ss[0]
+	last := ss[len(ss)-1]
 
 	for i := 0; i < len(first); i++ {
 		if last[i] != first[i] {
 			return i
 		}
 	}
 
-	return 0
+	return len(first)
 }
 
 func (sle *SlowlogEncoder) encodeStacktraceEntry(encoder zapcore.ObjectEncoder, entry phpfpm.SlowlogTraceEntry, pathOffset int) {
@@ -101,7 +101,7 @@ func (sle *SlowlogEncoder) Encode(entry phpfpm.SlowlogEntry) []zap.Field {
 
 	pathOffset := 0
 	if cutPrefix {
-		pathOffset = sle.longestCommonPrefOffset()
+		pathOffset = sle.longestCommonPrefOffset(sle.strBuf)
 	}
 
 	return []zap.Field{

internal/zapx/slowlog_enc_test.go

@@ -0,0 +1,59 @@
+package zapx
+
+import (
+	"testing"
+)
+
+func TestSlowlogEncoder_LongestCommonPrefOffset(t *testing.T) {
+	tests := []struct {
+		name     string
+		input    []string
+		expected int
+	}{
+		{
+			name:     "empty slice",
+			input:    []string{},
+			expected: 0,
+		},
+		{
+			name:     "single string",
+			input:    []string{"test"},
+			expected: 4,
+		},
+		{
+			name:     "no common prefix",
+			input:    []string{"abc", "def", "ghi"},
+			expected: 0,
+		},
+		{
+			name:     "partial common prefix",
+			input:    []string{"prefix123", "prefix456", "prefix789"},
+			expected: 6,
+		},
+		{
+			name:     "full common string",
+			input:    []string{"same", "same", "same"},
+			expected: 4,
+		},
+		{
+			name:     "mixed length strings with common prefix",
+			input:    []string{"test123", "test", "test4567"},
+			expected: 4,
+		},
+		{
+			name:     "strings with spaces",
+			input:    []string{"common prefix 1", "common prefix 2", "common prefix 3"},
+			expected: 14,
+		},
+	}
+
+	sle := &SlowlogEncoder{}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			result := sle.longestCommonPrefOffset(tt.input)
+			if result != tt.expected {
+				t.Errorf("longestCommonPrefOffset() = %v, want %v", result, tt.expected)
+			}
+		})
+	}
+}