Minor refactors

Author: code-shoily

.credo.exs

@@ -0,0 +1,88 @@
+# This file contains the configuration for Credo.
+#
+# For more information, see: https://hexdocs.pm/credo/config_file.html
+%{
+  configs: [
+    %{
+      name: "default",
+      files: %{
+        included: ["lib/", "src/", "web/", "apps/"],
+        excluded: [~r"/_build/", ~r"/deps/", ~r"/node_modules/"]
+      },
+      plugins: [],
+      requires: [],
+      strict: false,
+      parse_timeout: 5000,
+      color: true,
+      checks: [
+        # Disable cyclomatic complexity check - graph algorithms are naturally complex
+        {Credo.Check.Refactor.CyclomaticComplexity, false},
+
+        # Other checks we want to keep
+        {Credo.Check.Consistency.ExceptionNames, []},
+        {Credo.Check.Consistency.LineEndings, []},
+        {Credo.Check.Consistency.ParameterPatternMatching, []},
+        {Credo.Check.Consistency.SpaceAroundOperators, []},
+        {Credo.Check.Consistency.SpaceInParentheses, []},
+        {Credo.Check.Consistency.TabsOrSpaces, []},
+        {Credo.Check.Design.AliasUsage, [priority: :low, if_nested_deeper_than: 2, if_called_more_often_than: 0]},
+        {Credo.Check.Design.DuplicatedCode, [nodes_threshold: 3]},
+        {Credo.Check.Design.SkipTestWithoutComment, []},
+        {Credo.Check.Readability.AliasOrder, []},
+        {Credo.Check.Readability.FunctionNames, []},
+        {Credo.Check.Readability.LargeNumbers, []},
+        {Credo.Check.Readability.MaxLineLength, [priority: :low, max_length: 120]},
+        {Credo.Check.Readability.ModuleAttributeNames, []},
+        {Credo.Check.Readability.ModuleDoc, []},
+        {Credo.Check.Readability.ModuleNames, []},
+        {Credo.Check.Readability.ParenthesesInCondition, []},
+        {Credo.Check.Readability.ParenthesesOnZeroArityDefs, []},
+        {Credo.Check.Readability.PredicateFunctionNames, []},
+        {Credo.Check.Readability.PreferImplicitTry, []},
+        {Credo.Check.Readability.RedundantBlankLines, []},
+        {Credo.Check.Readability.Semicolons, []},
+        {Credo.Check.Readability.SpaceAfterCommas, []},
+        {Credo.Check.Readability.StringSigils, []},
+        {Credo.Check.Readability.TrailingBlankLine, []},
+        {Credo.Check.Readability.TrailingWhiteSpace, []},
+        {Credo.Check.Readability.UnnecessaryAliasExpansion, []},
+        {Credo.Check.Readability.VariableNames, []},
+        {Credo.Check.Readability.WithSingleClause, []},
+        {Credo.Check.Refactor.ABCSize, false},
+        {Credo.Check.Refactor.AppendSingleItem, []},
+        {Credo.Check.Refactor.DoubleBooleanNegation, []},
+        {Credo.Check.Refactor.FilterReject, []},
+        {Credo.Check.Refactor.IoPuts, []},
+        {Credo.Check.Refactor.MapJoin, []},
+        {Credo.Check.Refactor.NegatedConditionsInUnless, []},
+        {Credo.Check.Refactor.NegatedConditionsWithElse, []},
+        {Credo.Check.Refactor.Nesting, [max_nesting: 10]},
+        {Credo.Check.Refactor.RedundantWithClauseResult, []},
+        {Credo.Check.Refactor.RejectFilter, []},
+        {Credo.Check.Refactor.UnlessWithElse, []},
+        {Credo.Check.Refactor.VariableRebinding, []},
+        {Credo.Check.Refactor.WithClauses, []},
+        {Credo.Check.Warning.ApplicationConfigInModuleAttribute, []},
+        {Credo.Check.Warning.BoolOperationOnSameValues, []},
+        {Credo.Check.Warning.ExpensiveEmptyEnumCheck, []},
+        {Credo.Check.Warning.IExPry, []},
+        {Credo.Check.Warning.IoInspect, []},
+        {Credo.Check.Warning.MixEnv, []},
+        {Credo.Check.Warning.OperationOnSameValues, []},
+        {Credo.Check.Warning.OperationWithConstantResult, []},
+        {Credo.Check.Warning.RaiseInsideRescue, []},
+        {Credo.Check.Warning.SpecWithStruct, []},
+        {Credo.Check.Warning.UnsafeExec, []},
+        {Credo.Check.Warning.UnusedEnumOperation, []},
+        {Credo.Check.Warning.UnusedFileOperation, []},
+        {Credo.Check.Warning.UnusedKeywordOperation, []},
+        {Credo.Check.Warning.UnusedListOperation, []},
+        {Credo.Check.Warning.UnusedPathOperation, []},
+        {Credo.Check.Warning.UnusedRegexOperation, []},
+        {Credo.Check.Warning.UnusedStringOperation, []},
+        {Credo.Check.Warning.UnusedTupleOperation, []},
+        {Credo.Check.Warning.WrongTestFileExtension, []}
+      ]
+    }
+  ]
+}

lib/2016/day_08.ex

@@ -75,12 +75,8 @@ defmodule AdventOfCode.Y2016.Day08 do
       for w <- 0..(@width - 1) do
         IO.write(grid[{w, h}])
       end
-
-      IO.puts("")
     end
 
-    IO.puts("")
-
     :ok
   end
 

lib/2016/day_13.ex

@@ -60,7 +60,7 @@ defmodule AdventOfCode.Y2016.Day13 do
     |> MapSet.size()
   end
 
-  defp is_wall?(x, y, fav) do
+  defp wall?(x, y, fav) do
     if x < 0 or y < 0 do
       true
     else
@@ -71,7 +71,7 @@ defmodule AdventOfCode.Y2016.Day13 do
 
   defp open_neighbors({x, y}, fav) do
     [{x + 1, y}, {x - 1, y}, {x, y + 1}, {x, y - 1}]
-    |> Enum.filter(fn {nx, ny} -> not is_wall?(nx, ny, fav) end)
+    |> Enum.filter(fn {nx, ny} -> not wall?(nx, ny, fav) end)
   end
 
   defp count_ones(0), do: 0

lib/2019/day_08.ex

@@ -59,7 +59,6 @@ defmodule AdventOfCode.Y2019.Day08 do
     |> chunkify()
     |> List.first()
     |> Enum.map_join("\n", &Enum.join/1)
-    |> tap(&IO.puts/1)
   end
 
   defp chunkify(data) do

lib/2019/day_18.ex

@@ -109,21 +109,21 @@ defmodule AdventOfCode.Y2019.Day18 do
 
   defp find_pois(grid, start_chars) do
     grid
-    |> Enum.filter(fn {_, char} -> char in start_chars or is_key?(char) end)
+    |> Enum.filter(fn {_, char} -> char in start_chars or key?(char) end)
     |> Map.new(fn {pos, char} -> {char, pos} end)
   end
 
   defp find_pois_part_2(grid, start_chars) do
     grid
     |> Enum.filter(fn {_, char} ->
-      char in start_chars or is_key?(char)
+      char in start_chars or key?(char)
     end)
     |> Map.new(fn {pos, char} -> {char, pos} end)
   end
 
   defp calculate_keys_mask(pois) do
     Enum.reduce(pois, 0, fn {label, _}, acc ->
-      if is_key?(label), do: bor(acc, key_bit(label)), else: acc
+      if key?(label), do: bor(acc, key_bit(label)), else: acc
     end)
   end
 
@@ -150,7 +150,7 @@ defmodule AdventOfCode.Y2019.Day18 do
 
         # Record this key if we found one (but don't stop exploring!)
         new_acc =
-          if dist > 0 and is_key?(char) do
+          if dist > 0 and key?(char) do
             [%{to: char, dist: dist, required: mask} | acc]
           else
             acc
@@ -159,8 +159,8 @@ defmodule AdventOfCode.Y2019.Day18 do
         # Continue exploring - update mask with doors AND keys we pass through
         new_mask =
           cond do
-            is_door?(char) -> bor(mask, door_bit(char))
-            is_key?(char) -> bor(mask, key_bit(char))
+            door?(char) -> bor(mask, door_bit(char))
+            key?(char) -> bor(mask, key_bit(char))
             true -> mask
           end
 
@@ -181,8 +181,8 @@ defmodule AdventOfCode.Y2019.Day18 do
 
   defp neighbors({x, y}), do: [{x + 1, y}, {x - 1, y}, {x, y + 1}, {x, y - 1}]
 
-  defp is_key?(char), do: char != nil and char >= "a" and char <= "z"
-  defp is_door?(char), do: char != nil and char >= "A" and char <= "Z"
+  defp key?(char), do: char != nil and char >= "a" and char <= "z"
+  defp door?(char), do: char != nil and char >= "A" and char <= "Z"
 
   defp key_bit(char), do: bsl(1, hd(String.to_charlist(char)) - ?a)
   defp door_bit(char), do: bsl(1, hd(String.to_charlist(char)) - ?A)

lib/2022/day_12.ex

@@ -6,7 +6,7 @@ defmodule AdventOfCode.Y2022.Day12 do
   Tags: graph graph-traversal
   """
   alias AdventOfCode.Helpers.{InputReader, Transformers}
-  alias Yog.Builder.Grid
+  alias Yog.Builder.{Grid, GridGraph}
   alias Yog.Pathfinding.Dijkstra
   alias Yog.Transform
 
@@ -22,8 +22,8 @@ defmodule AdventOfCode.Y2022.Day12 do
 
     {sr, sc} = start_pos
     {er, ec} = end_pos
-    start_id = Yog.Builder.GridGraph.coord_to_id(builder, sr, sc)
-    end_id = Yog.Builder.GridGraph.coord_to_id(builder, er, ec)
+    start_id = GridGraph.coord_to_id(builder, sr, sc)
+    end_id = GridGraph.coord_to_id(builder, er, ec)
 
     # Part 1 and Part 2 are computed in parallel
     task_1 =

lib/2023/day_10.ex

@@ -6,7 +6,8 @@ defmodule AdventOfCode.Y2023.Day10 do
   Tags: graph bfs grid
   """
   alias AdventOfCode.Helpers.{InputReader, Transformers}
-  alias Yog.Builder.Grid
+  alias Yog.Builder.{Grid, GridGraph}
+  alias Yog.Model
   alias Yog.Pathfinding.Dijkstra
 
   def input, do: InputReader.read_from_file(2023, 10)
@@ -96,11 +97,11 @@ defmodule AdventOfCode.Y2023.Day10 do
       |> Enum.filter(&MapSet.member?(loop_nodes, &1))
 
     # Get coordinates of S and its neighbors to determine the pipe type
-    {sr, sc} = Yog.Builder.GridGraph.id_to_coord(grid_graph, start_id)
+    {sr, sc} = GridGraph.id_to_coord(grid_graph, start_id)
 
     s_offsets =
       Enum.map(s_neighbors, fn nid ->
-        {nr, nc} = Yog.Builder.GridGraph.id_to_coord(grid_graph, nid)
+        {nr, nc} = GridGraph.id_to_coord(grid_graph, nid)
         {nr - sr, nc - sc}
       end)
       |> MapSet.new()
@@ -123,11 +124,11 @@ defmodule AdventOfCode.Y2023.Day10 do
         {row_enclosed, _inside} =
           for c <- 0..(cols - 1), reduce: {0, false} do
             {count, inside} ->
-              id = Yog.Builder.GridGraph.coord_to_id(grid_graph, r, c)
+              id = GridGraph.coord_to_id(grid_graph, r, c)
 
               if MapSet.member?(loop_nodes, id) do
                 # Part of the loop - check if it's a boundary crossing
-                cell = Yog.Model.node(graph, id)
+                cell = Model.node(graph, id)
                 char = if cell.char == "S", do: s_char, else: cell.char
 
                 # Standard scan-line crossing logic: | L J flip whereas F 7 - do not
@@ -156,7 +157,7 @@ defmodule AdventOfCode.Y2023.Day10 do
     to_remove =
       Enum.filter(node_set, fn id ->
         degree =
-          Yog.Model.successors(graph, id)
+          Model.successors(graph, id)
           |> Enum.count(fn {neighbor, _} -> MapSet.member?(node_set, neighbor) end)
 
         degree < 2

lib/helpers/generator.ex

@@ -42,15 +42,15 @@ defmodule AdventOfCode.Helpers.Generator do
   end
 
   defp create_file(path, content) do
-    if !File.exists?(path) do
+    if File.exists?(path) do
+      {:exists, path}
+    else
       path |> Path.dirname() |> File.mkdir_p!()
 
       case File.write(path, content) do
         :ok -> {:ok, path}
         {:error, reason} -> {:error, path, reason}
       end
-    else
-      {:exists, path}
     end
   end
 
@@ -76,7 +76,9 @@ defmodule AdventOfCode.Helpers.Generator do
   end
 
   defp create_input_file(path, year, day) do
-    if !File.exists?(path) do
+    if File.exists?(path) do
+      {:exists, path}
+    else
       path |> Path.dirname() |> File.mkdir_p!()
 
       case fetch_cookie(year, day) do
@@ -89,8 +91,6 @@ defmodule AdventOfCode.Helpers.Generator do
         {:error, reason} ->
           {:error, path, reason}
       end
-    else
-      {:exists, path}
     end
   end
 

lib/helpers/helpers.ex

@@ -32,8 +32,6 @@ defmodule AdventOfCode.Helpers do
       for j <- 0..y do
         IO.write(grid[{i, j}])
       end
-
-      IO.puts("")
     end
   end
 end