Skip to content

Commit d2964df

Browse files
committed
reintroduced DEFAULT_FROM_EMAIL
1 parent c0652e3 commit d2964df

5 files changed

Lines changed: 6 additions & 4 deletions

File tree

.env_sample

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ SELENIUM_HOSTNAME=selenium
4545
#EMAIL_HOST_PASSWORD=pass
4646
#EMAIL_PORT=587
4747
#EMAIL_USE_TLS=True
48+
#DEFAULT_FROM_EMAIL="Codabench <noreply@example.com>"
4849
#SERVER_EMAIL=noreply@example.com
4950

5051
# Contact Email

src/apps/forums/helpers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ def send_mail(context=None, from_email=None, html_file=None, text_file=None, sub
1515
:param subject: Email's subject.
1616
:param to_email: Recipient's email.
1717
"""
18-
from_email = from_email if from_email else settings.SERVER_EMAIL
18+
from_email = from_email if from_email else settings.DEFAULT_FROM_EMAIL
1919

2020
context["site"] = Site.objects.get_current()
2121

src/apps/profiles/helpers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ def send_mail(context=None, from_email=None, html_file=None, text_file=None, sub
1515
:param subject: Email's subject.
1616
:param to_email: Recipient's email.
1717
"""
18-
from_email = from_email if from_email else settings.SERVER_EMAIL
18+
from_email = from_email if from_email else settings.DEFAULT_FROM_EMAIL
1919

2020
context["site"] = Site.objects.get_current()
2121

src/settings/base.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -544,6 +544,7 @@ def setup_celery_logging(**kwargs):
544544
EMAIL_HOST_PASSWORD = os.environ.get('EMAIL_HOST_PASSWORD')
545545
EMAIL_PORT = os.environ.get('EMAIL_PORT', 587)
546546
EMAIL_USE_TLS = os.environ.get('EMAIL_USE_TLS', True)
547+
DEFAULT_FROM_EMAIL = os.environ.get('DEFAULT_FROM_EMAIL', 'Codabench <noreply@codabench.org>')
547548
SERVER_EMAIL = os.environ.get('SERVER_EMAIL', 'noreply@codabench.org')
548549

549550
CONTACT_EMAIL = os.environ.get('CONTACT_EMAIL', 'info@codabench.org')

src/utils/email.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88

99
def codalab_send_mail(context_data, to_email, html_file, text_file, subject, from_email=None):
10-
from_email = from_email if from_email else settings.SERVER_EMAIL
10+
from_email = from_email if from_email else settings.DEFAULT_FROM_EMAIL
1111

1212
context_data["site"] = Site.objects.get_current()
1313

@@ -40,7 +40,7 @@ def sanitize(content):
4040

4141

4242
def codalab_send_markdown_email(subject, markdown_content, recipient_list, from_email=None):
43-
from_email = from_email if from_email else settings.SERVER_EMAIL
43+
from_email = from_email if from_email else settings.DEFAULT_FROM_EMAIL
4444
html_message = markdown.markdown(markdown_content)
4545
# message = sanitize(markdown_content)
4646
# html_message = sanitize(markdown.markdown(message))

0 commit comments

Comments
 (0)