Avoid errors for missing submission results when dealing with datasets

Creating a dataset without copying the results do not create empty
ones, but leave the submission without a result for the new
dataset. The code dealing with results needs to be made aware that
this might happen. In particular, this was not true for ProxyService
(when making the new dataset live) and for ES (when enabling
background judging).

Author: stefano-maggiolo

cms/service/EvaluationService.py

@@ -3,7 +3,7 @@
 
 # Contest Management System - http://cms-dev.github.io/
 # Copyright © 2010-2014 Giovanni Mascellani <mascellani@poisson.phc.unipi.it>
-# Copyright © 2010-2014 Stefano Maggiolo <s.maggiolo@gmail.com>
+# Copyright © 2010-2015 Stefano Maggiolo <s.maggiolo@gmail.com>
 # Copyright © 2010-2012 Matteo Boscariol <boscarim@hotmail.com>
 # Copyright © 2013 Luca Wehrstedt <luca.wehrstedt@gmail.com>
 # Copyright © 2013 Bernard Blackham <bernard@largestprime.net>
@@ -1196,10 +1196,22 @@ def action_finished(self, data, plus, error=None):
                 submission_result = SubmissionResult.get_from_id(
                     (object_id, dataset_id), session)
                 if submission_result is None:
-                    logger.error("[action_finished] Couldn't find "
-                                 "submission %d(%d) in the database.",
-                                 object_id, dataset_id)
-                    return
+                    logger.info("[action_finished] Couldn't find "
+                                "submission %d(%d) in the database. "
+                                "Creating it.", object_id, dataset_id)
+                    submission = Submission.get_from_id(object_id, session)
+                    dataset = Dataset.get_from_id(dataset_id, session)
+                    if submission is None:
+                        logger.error("[action_finished] Could not find "
+                                     "submission %d in the database.",
+                                     object_id)
+                        return
+                    if dataset is None:
+                        logger.error("[action_finished] Could not find "
+                                     "dataset %d in the database.", dataset_id)
+                        return
+                    submission_result = submission.get_result_or_create(
+                        dataset)
 
                 submission_result.compilation_tries += 1
 

cms/service/ProxyService.py

@@ -3,7 +3,7 @@
 
 # Contest Management System - http://cms-dev.github.io/
 # Copyright © 2010-2013 Giovanni Mascellani <mascellani@poisson.phc.unipi.it>
-# Copyright © 2010-2014 Stefano Maggiolo <s.maggiolo@gmail.com>
+# Copyright © 2010-2015 Stefano Maggiolo <s.maggiolo@gmail.com>
 # Copyright © 2010-2012 Matteo Boscariol <boscarim@hotmail.com>
 # Copyright © 2013 Luca Wehrstedt <luca.wehrstedt@gmail.com>
 # Copyright © 2013 Bernard Blackham <bernard@largestprime.net>
@@ -278,7 +278,13 @@ def _missing_operations(self):
                 if submission.user.hidden:
                     continue
 
-                if submission.get_result().scored() and \
+                # The submission result can be None if the dataset has
+                # been just made live.
+                sr = submission.get_result()
+                if sr is None:
+                    continue
+
+                if sr.scored() and \
                         submission.id not in self.scores_sent_to_rankings:
                     for operation in self.operations_for_score(submission):
                         self.enqueue(operation)
@@ -509,6 +515,7 @@ def dataset_updated(self, task_id):
             for submission in task.submissions:
                 # Update RWS.
                 if not submission.user.hidden and \
+                        submission.get_result() is not None and \
                         submission.get_result().scored():
                     for operation in self.operations_for_score(submission):
                         self.enqueue(operation)