Return rejected promise when AMI URL is invalid

Author: clue

README.md

@@ -100,8 +100,8 @@ $factory = new Factory($loop, $connector);
 #### createClient()
 
 The `createClient(string $amiUrl): PromiseInterface<Client>` method can be used to create a new [`Client`](#client).
-It helps with establishing a plain TCP/IP or secure SSL/TLS connection to the AMI
-and issuing an initial `login` action.
+It helps with establishing a plain TCP/IP or secure TLS connection to the AMI
+and optionally issuing an initial `login` action.
 
 ```php
 $factory->createClient($amiUrl)->then(
@@ -114,6 +114,10 @@ $factory->createClient($amiUrl)->then(
 );
 ```
 
+The method returns a [Promise](https://github.com/reactphp/promise) that will
+resolve with the [`Client`](#client) instance on success or will reject with an
+`Exception` if the URL is invalid or the connection or authentication fails.
+
 The `$amiUrl` contains the host and optional port to connect to:
 
 ```php

composer.json

@@ -14,7 +14,7 @@
         "php": ">=5.3",
         "evenement/evenement": "^3.0 || ^2.0 || ^1.0",
         "react/event-loop": "^1.0 || ^0.5 || ^0.4 || ^0.3",
-        "react/promise": "^2.0 || ^1.0",
+        "react/promise": "^2.0 || ^1.1",
         "react/socket": "^1.0 || ^0.8.2"
     },
     "require-dev": {

src/Factory.php

@@ -7,6 +7,7 @@
 use React\Socket\Connector;
 use React\Socket\ConnectorInterface;
 use InvalidArgumentException;
+use React\Promise;
 
 class Factory
 {
@@ -25,7 +26,11 @@ public function __construct(LoopInterface $loop, ConnectorInterface $connector =
 
     public function createClient($address = null)
     {
-        $parts = $this->parseUrl($address);
+        try {
+            $parts = $this->parseUrl($address);
+        } catch (\Exception $e) {
+            return Promise\reject($e);
+        }
 
         if (isset($parts['scheme']) && $parts['scheme'] !== 'tcp') {
             $parts['host'] = 'tls://' . $parts['host'];

tests/FactoryTest.php

@@ -2,6 +2,7 @@
 
 use Clue\React\Ami\Factory;
 use React\Promise\Promise;
+
 class FactoryTest extends TestCase
 {
     private $loop;
@@ -44,4 +45,11 @@ public function testCreateClientUsesTlsConnectorWithTlsLocation()
 
         $this->factory->createClient('tls://ami.local:1234');
     }
+
+    public function testCreateClientWithInvalidUrlWillRejectPromise()
+    {
+        $promise = $this->factory->createClient('///');
+
+        $promise->then(null, $this->expectCallableOnce());
+    }
 }