Unit tests for collector

Author: clue

src/Collector.php

@@ -4,8 +4,6 @@
 
 use Clue\React\Ami\Client;
 use Clue\React\Ami\Protocol\Response;
-use Clue\React\Ami\Protocol\Action;
-use UnexpectedValueException;
 use Clue\React\Ami\Protocol\Event;
 use Clue\React\Ami\Protocol\Collection;
 use React\Promise\Deferred;
@@ -36,7 +34,7 @@ public function agents()
 
     private function collectEvents($command, $expectedEndEvent)
     {
-        $req = new Action($command);
+        $req = $this->client->createAction($command);
         $ret = $this->client->request($req);
         $id = $req->getActionId();
 

tests/CollectorTest.php

@@ -0,0 +1,60 @@
+<?php
+
+use Clue\React\Ami\Collector;
+use Clue\React\Ami\Protocol\Collection;
+use Clue\React\Ami\Protocol\Response;
+use Clue\React\Ami\Client;
+use Clue\React\Ami\Protocol\Event;
+use Clue\React\Ami\Protocol\Action;
+
+class CollectorTest extends TestCase
+{
+    public function testCollectingSIPEvents()
+    {
+        $client = $this->createClientMock();
+
+        // expect a single outgoing action request (and mock its ID)
+        $client->expects($this->once())
+                 ->method('createAction')
+                 ->with($this->equalTo('SIPPeers'), $this->equalTo(array()))
+                 ->will($this->returnValue(new Action('SIPPeers', array('ActionID' => '123'))));
+
+        $collector = new Collector($client);
+
+        $promise = $collector->sipPeers();
+
+        // save resolved result for comparisions
+        $resolved = null;
+        $promise->then(function($result) use (&$resolved) {
+            $resolved = $result;
+        });
+
+        // should not start out resolved
+        $this->assertNull($resolved);
+
+        $response = new Response(array('Response' => 'Success', 'ActionID' => '123'));
+
+        $client->handleMessage($response);
+        $client->handleMessage(new Event('PeerEntry', array('ActionID' => '123')));
+        $client->handleMessage(new Event('PeerEntry', array('ActionID' => '123')));
+
+        $this->assertNull($resolved);
+
+        $client->handleMessage(new Event('PeerlistComplete', array('EventList' => 'complete', 'ListItems' => '2', 'ActionID' => '123')));
+
+        $this->assertNotNull($resolved);
+
+        $promise->then(
+            $this->expectCallableOnce()
+        );
+    }
+
+    private function createClientMock()
+    {
+        $stream = $this->getMockBuilder('React\Stream\Stream')->disableOriginalConstructor()->getMock();
+
+        $client = $this->getMockBuilder('Clue\React\Ami\Client')->setMethods(array('createAction'))->setConstructorArgs(array($stream))->getMock();
+
+        return $client;
+    }
+}