Forward parser Exception as a Client error (closes #4)

Author: clue

src/Client.php

@@ -9,6 +9,7 @@
 use Clue\React\Ami\Protocol\Parser;
 use React\Promise\Deferred;
 use Exception;
+use UnexpectedValueException;
 use Clue\React\Ami\Protocol\Message;
 use Clue\React\Ami\Protocol\ErrorException;
 
@@ -28,11 +29,20 @@ public function __construct(StreamInterface $stream, Parser $parser = null)
 
         $that = $this;
         $this->stream->on('data', function ($chunk) use ($parser, $that) {
-            foreach ($parser->push($chunk) as $message) {
+            try {
+                $messages = $parser->push($chunk);
+            } catch (UnexpectedValueException $e) {
+                $that->emit('error', array($e, $this));
+                return;
+            }
+
+            foreach ($messages as $message) {
                 $that->handleMessage($message);
             }
         });
 
+        $this->on('error', array($that, 'close'));
+
         $this->stream->on('close', array ($that, 'close'));
 
         $this->stream->resume();

tests/ClientTest.php

@@ -18,4 +18,17 @@ public function testClosingStreamClosesClient()
         $stream->close();
         //$stream->emit('close', array($this));
     }
+
+    public function testParserExceptionForwardsErrorAndClosesClient()
+    {
+        $stream = new ThroughStream();
+        $parser = new Parser();
+
+        $client = new Client($stream, $parser);
+
+        $client->on('error', $this->expectCallableOnce());
+        $client->on('close', $this->expectCallableOnce());
+
+        $stream->emit('data', array("invalid chunk\r\n\r\ninvalid chunk\r\n\r\n"));
+    }
 }