Inject SocketClient via ConnectorInterface

Author: clue

src/Factory.php

@@ -3,6 +3,7 @@
 namespace Clue\React\Ami;
 
 use React\EventLoop\LoopInterface;
+use React\SocketClient\ConnectorInterface;
 use React\SocketClient\Connector;
 use React\SocketClient\SecureConnector;
 use React\Dns\Resolver\Factory as ResolverFactory;
@@ -15,7 +16,7 @@ class Factory
     private $connector;
     private $secureConnector;
 
-    public function __construct(LoopInterface $loop, Connector $connector = null, SecureConnector $secureConnector = null)
+    public function __construct(LoopInterface $loop, ConnectorInterface $connector = null, ConnectorInterface $secureConnector = null)
     {
         if ($connector === null) {
             $resolverFactory = new ResolverFactory();

tests/FactoryTest.php

@@ -0,0 +1,41 @@
+<?php
+
+use Clue\React\Ami\Factory;
+use React\Promise\Promise;
+class FactoryTest extends TestCase
+{
+    private $loop;
+    private $tcp;
+    private $tls;
+    private $factory;
+
+    public function setUp()
+    {
+        $this->loop = $this->getMockBuilder('React\EventLoop\LoopInterface')->getMock();
+        $this->tcp = $this->getMockBuilder('React\SocketClient\ConnectorInterface')->getMock();
+        $this->tls = $this->getMockBuilder('React\SocketClient\ConnectorInterface')->getMock();
+
+        $this->factory = new Factory($this->loop, $this->tcp, $this->tls);
+    }
+
+    public function testDefaultCtor()
+    {
+        $this->factory = new Factory($this->loop);
+    }
+
+    public function testCreateClientUsesTcpConnectorWithDefaultLocation()
+    {
+        $promise = new Promise(function () { });
+        $this->tcp->expects($this->once())->method('create')->with('127.0.0.1', 5038)->willReturn($promise);
+
+        $this->factory->createClient();
+    }
+
+    public function testCreateClientUsesTcpConnectorWithLocalhostLocation()
+    {
+        $promise = new Promise(function () { });
+        $this->tcp->expects($this->once())->method('create')->with('127.0.0.1', 5038)->willReturn($promise);
+
+        $this->factory->createClient('localhost');
+    }
+}