refactor(iamUser/Role/Policy): Change name of promise resolution clbk

Author: M1kep

src/services/iamPolicy/data.ts

@@ -47,7 +47,7 @@ const tagsByPolicyArn = async (
   iam: IAM,
   { Arn }: Policy
 ): Promise<{ Arn: string; Tags: TagMap }> =>
-  new Promise(resolveUserPolicies => {
+  new Promise(resolve => {
     iam.listPolicyTags(
       { PolicyArn: Arn },
       (err: AWSError, data: ListPolicyTagsResponse) => {
@@ -60,13 +60,13 @@ const tagsByPolicyArn = async (
 
         if (!isEmpty(data)) {
           const { Tags: tags = [] } = data
-          resolveUserPolicies({
+          resolve({
             Arn,
             Tags: convertAwsTagsToTagMap(tags),
           })
         }
 
-        resolveUserPolicies(null)
+        resolve(null)
       }
     )
   })
@@ -75,7 +75,7 @@ const policyVersionByPolicyArn = async (
   iam: IAM,
   { Arn, DefaultVersionId }: Policy
 ): Promise<{ Arn: string; Content: string }> =>
-  new Promise(resolveUserPolicies => {
+  new Promise(resolve => {
     iam.getPolicyVersion(
       { PolicyArn: Arn, VersionId: DefaultVersionId },
       (err: AWSError, data: GetPolicyVersionResponse) => {
@@ -88,13 +88,13 @@ const policyVersionByPolicyArn = async (
 
         if (!isEmpty(data)) {
           const { PolicyVersion = { Document: '' } } = data
-          resolveUserPolicies({
+          resolve({
             Arn,
             Content: decodeURIComponent(PolicyVersion.Document),
           })
         }
 
-        resolveUserPolicies(null)
+        resolve(null)
       }
     )
   })

src/services/iamRole/data.ts

@@ -76,7 +76,7 @@ const tagsByRoleName = async (
   iam: IAM,
   { RoleName }: Role
 ): Promise<{ RoleName: string; Tags: TagMap }> =>
-  new Promise(resolveUserPolicies => {
+  new Promise(resolve => {
     iam.listRoleTags(
       { RoleName },
       (err: AWSError, data: ListRoleTagsResponse) => {
@@ -90,13 +90,13 @@ const tagsByRoleName = async (
         if (!isEmpty(data)) {
           const { Tags: tags = [] } = data
 
-          resolveUserPolicies({
+          resolve({
             RoleName,
             Tags: convertAwsTagsToTagMap(tags),
           })
         }
 
-        resolveUserPolicies(null)
+        resolve(null)
       }
     )
   })
@@ -105,7 +105,7 @@ const policiesByRoleName = async (
   iam: IAM,
   { RoleName }: Role
 ): Promise<{ RoleName: string; Policies: string[] }> =>
-  new Promise(resolveUserPolicies => {
+  new Promise(resolve => {
     iam.listRolePolicies(
       { RoleName },
       (err: AWSError, data: ListRolePoliciesResponse) => {
@@ -119,10 +119,10 @@ const policiesByRoleName = async (
         if (!isEmpty(data)) {
           const { PolicyNames = [] } = data
 
-          resolveUserPolicies({ RoleName, Policies: PolicyNames })
+          resolve({ RoleName, Policies: PolicyNames })
         }
 
-        resolveUserPolicies(null)
+        resolve(null)
       }
     )
   })
@@ -131,7 +131,7 @@ const managedPoliciesByRoleName = async (
   iam: IAM,
   { RoleName }: Role
 ): Promise<{ RoleName: string; ManagedPolicies: AttachedPolicy[] }> =>
-  new Promise(resolveUserPolicies => {
+  new Promise(resolve => {
     iam.listAttachedRolePolicies(
       { RoleName },
       (err: AWSError, data: ListAttachedRolePoliciesResponse) => {
@@ -145,13 +145,13 @@ const managedPoliciesByRoleName = async (
         if (!isEmpty(data)) {
           const { AttachedPolicies = [] } = data
 
-          resolveUserPolicies({
+          resolve({
             RoleName,
             ManagedPolicies: AttachedPolicies,
           })
         }
 
-        resolveUserPolicies(null)
+        resolve(null)
       }
     )
   })

src/services/iamUser/data.ts

@@ -91,7 +91,7 @@ const tagsByUsername = async (
   iam: IAM,
   { UserName }: User
 ): Promise<{ UserName: string; Tags: TagMap }> =>
-  new Promise(resolveUserPolicies => {
+  new Promise(resolve => {
     iam.listUserTags(
       { UserName },
       (err: AWSError, data: ListUserTagsResponse) => {
@@ -105,10 +105,10 @@ const tagsByUsername = async (
         if (!isEmpty(data)) {
           const { Tags: tags = [] } = data
 
-          resolveUserPolicies({ UserName, Tags: convertAwsTagsToTagMap(tags) })
+          resolve({ UserName, Tags: convertAwsTagsToTagMap(tags) })
         }
 
-        resolveUserPolicies(null)
+        resolve(null)
       }
     )
   })
@@ -117,7 +117,7 @@ const groupsByUsername = async (
   iam: IAM,
   { UserName }: User
 ): Promise<{ UserName: string; Groups: string[] }> =>
-  new Promise(resolveUserGroups => {
+  new Promise(resolve => {
     iam.listGroupsForUser(
       { UserName },
       (err: AWSError, data: ListGroupsForUserResponse) => {
@@ -133,10 +133,10 @@ const groupsByUsername = async (
 
           const userGroups = Groups.map(({ GroupId }) => GroupId)
 
-          resolveUserGroups({ UserName, Groups: userGroups })
+          resolve({ UserName, Groups: userGroups })
         }
 
-        resolveUserGroups(null)
+        resolve(null)
       }
     )
   })
@@ -145,7 +145,7 @@ const policiesByUsername = async (
   iam: IAM,
   { UserName }: User
 ): Promise<{ UserName: string; Policies: string[] }> =>
-  new Promise(resolveUserPolicies => {
+  new Promise(resolve => {
     iam.listUserPolicies(
       { UserName },
       (err: AWSError, data: ListUserPoliciesResponse) => {
@@ -159,10 +159,10 @@ const policiesByUsername = async (
         if (!isEmpty(data)) {
           const { PolicyNames = [] } = data
 
-          resolveUserPolicies({ UserName, Policies: PolicyNames })
+          resolve({ UserName, Policies: PolicyNames })
         }
 
-        resolveUserPolicies(null)
+        resolve(null)
       }
     )
   })
@@ -171,7 +171,7 @@ const managedPoliciesByUsername = async (
   iam: IAM,
   { UserName }: User
 ): Promise<{ UserName: string; ManagedPolicies: AttachedPolicy[] }> =>
-  new Promise(resolveUserPolicies => {
+  new Promise(resolve => {
     iam.listAttachedUserPolicies(
       { UserName },
       (err: AWSError, data: ListAttachedUserPoliciesResponse) => {
@@ -185,13 +185,13 @@ const managedPoliciesByUsername = async (
         if (!isEmpty(data)) {
           const { AttachedPolicies = [] } = data
 
-          resolveUserPolicies({
+          resolve({
             UserName,
             ManagedPolicies: AttachedPolicies,
           })
         }
 
-        resolveUserPolicies(null)
+        resolve(null)
       }
     )
   })