Merge pull request #62 from cloudgraphdev/fix/CG-1194-v3

fix: Added missing return to resolve promise

Author: tyler-dunkel

src/services/apiGatewayRestApi/data.ts

@@ -113,7 +113,7 @@ const getAPIMappings = (
            * No Data for the region
            */
           if (isEmpty(data)) {
-            resolveBasePathMapping({
+            return resolveBasePathMapping({
               domainName,
               restApiData: [],
             })

src/services/cloudfront/data.ts

@@ -68,7 +68,7 @@ const listCloudfrontDistributions = async (
            * No Distributions Found
            */
           if (isEmpty(Items)) {
-            resolve([])
+            return resolve([])
           }
 
           distributions.push(...Items)

src/services/elasticBeanstalkApplication/data.ts

@@ -41,11 +41,11 @@ const listApplications = async (
          * No EB Applications for this region
          */
         if (isEmpty(data)) {
-          resolve([])
+          return resolve([])
         }
         const { Applications = [] } = data || {}
         if (isEmpty(Applications)) {
-          resolve([])
+          return resolve([])
         }
         resolve(Applications)
       }
@@ -72,11 +72,11 @@ export const getResourceTags = async (
          * No EB Applications for this region
          */
         if (isEmpty(data)) {
-          resolveTags({})
+          return resolveTags({})
         }
         const { ResourceTags: tags } = data || {}
         if (isEmpty(tags)) {
-          resolveTags({})
+          return resolveTags({})
         }
         resolveTags(convertAwsTagsToTagMap(tags as AwsTag[]))
       }

src/services/sns/data.ts

@@ -171,11 +171,15 @@ const getTopicSubscriptions = async (
             }
 
             if (isEmpty(data)) {
-              resolveSubscriptions([])
+              return resolveSubscriptions([])
             }
 
             const { Subscriptions, NextToken } = data || {}
 
+            if (isEmpty(Subscriptions)) {
+              return resolveSubscriptions([])
+            }
+
             subscriptions.push(...Subscriptions)
 
             if (NextToken) {