Skip to content

Commit b9c16e9

Browse files
committed
Merge branch 'fix/lambda-and-kms-fixes' into 'master'
fix(services): fix lambda to include vpcConfig, fix kms to use booleans See merge request auto-cloud/cloudgraph/provider/cloudgraph-provider-aws!219
2 parents 9863371 + cff6a70 commit b9c16e9

5 files changed

Lines changed: 28 additions & 6 deletions

File tree

src/services/kms/format.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,10 @@ export default ({
4040
region,
4141
id,
4242
description,
43-
keyRotationEnabled: keyRotationEnabled ? t.yes : t.no,
43+
keyRotationEnabled,
4444
usage,
4545
policy: formatIamJsonPolicy(policy),
46-
enabled: enabled ? t.yes : t.no,
46+
enabled,
4747
keyState,
4848
customerMasterKeySpec,
4949
tags: formatTagsFromMap(Tags),

src/services/kms/schema.graphql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@ type awsKms @key(fields: "id"){
44
arn: String! @id @search(by: [hash, regexp])
55
region: String @search(by: [hash, regexp])
66
description: String @search(by: [hash, regexp, fulltext])
7-
keyRotationEnabled: String @search(by: [hash, regexp])
7+
keyRotationEnabled: Boolean @search
88
usage: String @search(by: [hash, regexp])
99
policy: awsIamJSONPolicy
10-
enabled: String @search(by: [hash, regexp])
10+
enabled: Boolean @search
1111
keyState: String @search(by: [hash, regexp])
1212
customerMasterKeySpec: String @search(by: [hash, regexp])
1313
tags: [awsRawTag]

src/services/lambda/format.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ export default ({
3131
TracingConfig: tracing = [],
3232
Version: version,
3333
reservedConcurrentExecutions: rawReservedConcurrentExecutions,
34+
VpcConfig: vpcConfig
3435
} = rawData
3536
const environmentVariables = []
3637
const secretNames = [t.pass, t.secret, t.private, t.cert]
@@ -56,6 +57,12 @@ export default ({
5657
.map(([key, value]) => `${key} - ${value}`)
5758
.join(', ')
5859

60+
const formattedVpcConfig = {
61+
vpcId: vpcConfig?.VpcId,
62+
subnetIds: vpcConfig?.SubnetIds,
63+
securityGroupIds: vpcConfig?.SecurityGroupIds
64+
}
65+
5966
return {
6067
accountId: account,
6168
arn,
@@ -74,6 +81,7 @@ export default ({
7481
tracingConfig,
7582
version,
7683
environmentVariables,
84+
vpcConfig: formattedVpcConfig,
7785
tags: formatTagsFromMap(Tags),
7886
}
7987
}

src/services/lambda/schema.graphql

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ type awsLambda @key(fields: "arn") {
1616
tracingConfig: String @search(by: [hash, regexp])
1717
version: String @search(by: [hash, regexp])
1818
environmentVariables: [awsLambdaEnvironmentVariable]
19+
vpcConfig: awsLambdaVpcConfig
1920
tags: [awsRawTag]
2021
kms: [awsKms] @hasInverse(field: lambda)
2122
securityGroups: [awsSecurityGroup] @hasInverse(field: lambda)
@@ -35,3 +36,9 @@ type awsLambdaEnvironmentVariable
3536
key: String!
3637
value: String
3738
}
39+
40+
type awsLambdaVpcConfig {
41+
vpcId: String @search(by: [hash, regexp])
42+
subnetIds: [String] @search(by: [hash, regexp])
43+
securityGroupIds: [String] @search(by: [hash, regexp])
44+
}

src/types/generated.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3313,10 +3313,10 @@ export type AwsKms = {
33133313
elastiCacheReplicationGroup?: Maybe<Array<Maybe<AwsElastiCacheReplicationGroup>>>;
33143314
elasticSearchDomains?: Maybe<Array<Maybe<AwsElasticSearchDomain>>>;
33153315
emrCluster?: Maybe<Array<Maybe<AwsEmrCluster>>>;
3316-
enabled?: Maybe<Scalars['String']>;
3316+
enabled?: Maybe<Scalars['Boolean']>;
33173317
id: Scalars['String'];
33183318
keyManager?: Maybe<Scalars['String']>;
3319-
keyRotationEnabled?: Maybe<Scalars['String']>;
3319+
keyRotationEnabled?: Maybe<Scalars['Boolean']>;
33203320
keyState?: Maybe<Scalars['String']>;
33213321
lambda?: Maybe<Array<Maybe<AwsLambda>>>;
33223322
origin?: Maybe<Scalars['String']>;
@@ -3355,6 +3355,7 @@ export type AwsLambda = {
33553355
tracingConfig?: Maybe<Scalars['String']>;
33563356
version?: Maybe<Scalars['String']>;
33573357
vpc?: Maybe<Array<Maybe<AwsVpc>>>;
3358+
vpcConfig?: Maybe<AwsLambdaVpcConfig>;
33583359
};
33593360

33603361
export type AwsLambdaEnvironmentVariable = {
@@ -3363,6 +3364,12 @@ export type AwsLambdaEnvironmentVariable = {
33633364
value?: Maybe<Scalars['String']>;
33643365
};
33653366

3367+
export type AwsLambdaVpcConfig = {
3368+
securityGroupIds?: Maybe<Array<Maybe<Scalars['String']>>>;
3369+
subnetIds?: Maybe<Array<Maybe<Scalars['String']>>>;
3370+
vpcId?: Maybe<Scalars['String']>;
3371+
};
3372+
33663373
export type AwsLaunchConfiguration = {
33673374
associatePublicIpAddress?: Maybe<Scalars['String']>;
33683375
blockDeviceMappings?: Maybe<Array<Maybe<AwsLcBlockDeviceMapping>>>;

0 commit comments

Comments
 (0)