Skip to content

Commit 96915f3

Browse files
author
Marco Franceschi
committed
fix: Fixed issues scanning sageMakerExperiment and sageMakerProject
1 parent e33ff2e commit 96915f3

2 files changed

Lines changed: 11 additions & 8 deletions

File tree

src/services/sageMakerExperiment/data.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import groupBy from 'lodash/groupBy'
44
import { convertToPromise, fetchAllPaginatedData } from '../../utils/fetchUtils'
55
import { initTestEndpoint } from '../../utils'
66
import ErrorLog from '../../utils/errorLog'
7+
import { isEmpty } from 'lodash'
78

89
const serviceName = 'sageMakerExperiment'
910
const errorLog = new ErrorLog(serviceName)
@@ -24,13 +25,13 @@ export default async ({
2425
}: {
2526
regions: string
2627
config: Config
27-
}): Promise<{[region: string]: RawAwsSageMakerExperiment[]}> => {
28+
}): Promise<{ [region: string]: RawAwsSageMakerExperiment[] }> => {
2829
const result: RawAwsSageMakerExperiment[] = []
2930

3031
const activeRegions = regions.split(',')
3132

3233
for (const region of activeRegions) {
33-
let sageMakerExperimentData: SAGEMAKER.ExperimentSummary[]
34+
let sageMakerExperimentData: SAGEMAKER.ExperimentSummary[] = []
3435
try {
3536
sageMakerExperimentData = await fetchAllPaginatedData({
3637
getResourcesFn: convertToPromise({
@@ -42,11 +43,12 @@ export default async ({
4243
} catch (err) {
4344
errorLog.generateAwsErrorLog({
4445
functionName: 'listExperiments',
45-
err
46+
err,
4647
})
4748
}
4849

49-
result.push(...sageMakerExperimentData.map(val => ({ ... val, region })))
50+
if (!isEmpty(sageMakerExperimentData))
51+
result.push(...sageMakerExperimentData.map(val => ({ ...val, region })))
5052
}
5153

5254
return groupBy(result, 'region')

src/services/sageMakerProject/data.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { Config } from 'aws-sdk/lib/config'
22
import SAGEMAKER from 'aws-sdk/clients/sagemaker'
3-
import { groupBy } from 'lodash'
3+
import { groupBy, isEmpty } from 'lodash'
44
import { convertToPromise, fetchAllPaginatedData } from '../../utils/fetchUtils'
55
import { initTestEndpoint } from '../../utils'
66
import ErrorLog from '../../utils/errorLog'
@@ -29,7 +29,7 @@ export default async ({
2929
const activeRegions = regions.split(',')
3030

3131
for (const region of activeRegions) {
32-
let sageMakerProjectData: SAGEMAKER.ProjectSummary[]
32+
let sageMakerProjectData: SAGEMAKER.ProjectSummary[] = []
3333
try {
3434
sageMakerProjectData = await fetchAllPaginatedData({
3535
getResourcesFn: convertToPromise({
@@ -41,11 +41,12 @@ export default async ({
4141
} catch (err) {
4242
errorLog.generateAwsErrorLog({
4343
functionName: 'sageMakerProject:listProjects',
44-
err
44+
err,
4545
})
4646
}
4747

48-
result.push(...sageMakerProjectData.map(val => ({ ...val, region })))
48+
if (!isEmpty(sageMakerProjectData))
49+
result.push(...sageMakerProjectData.map(val => ({ ...val, region })))
4950
}
5051
errorLog.reset()
5152
return groupBy(result, 'region')

0 commit comments

Comments
 (0)