Merge pull request #27 from mctaylorpants/replace-keys-patch

Prevent ActiveRecord from reloading associated records when the STI name is different

Author: Kyle d'Oliveira

lib/polymorphic_integer_type.rb

@@ -14,4 +14,8 @@
   require "polymorphic_integer_type/activerecord_5_0_0/association_query_handler_extension"
 end
 
+if ACTIVE_RECORD_VERSION < Gem::Version.new("5.2.0")
+  require "polymorphic_integer_type/activerecord_4/belongs_to_polymorphic_association_extension"
+end
+
 module PolymorphicIntegerType; end

lib/polymorphic_integer_type/activerecord_4/belongs_to_polymorphic_association_extension.rb

@@ -0,0 +1,10 @@
+module ActiveRecord
+  module Associations
+    class BelongsToPolymorphicAssociation < BelongsToAssociation
+      private def replace_keys(record)
+        super
+        owner[reflection.foreign_type] = record.class.base_class
+      end
+    end
+  end
+end

spec/polymorphic_integer_type_spec.rb

@@ -24,11 +24,19 @@
     end
   end
 
-  context "when the source is a class that modifies the sti_name" do
+  context "when the source is a class that modifies the sti_name or polymorphic_name" do
     it "properly sets the source_type to the modified class name" do
       link = Link.new(source: Namespaced::Animal.new)
       expect(link.source_type).to eql "Animal"
     end
+
+    it "can read dirty attributes from an associated object" do
+      animal = Namespaced::Animal.create!(name: "Oldie")
+      animal.name = "Newton"
+      link = Link.create!(source: animal)
+
+      expect(link.source.name).to eq("Newton")
+    end
   end
 
   context "when querying the associations" do
@@ -109,7 +117,7 @@
 
   end
 
-  context "When using a relation to the links with eagar loading" do
+  context "When using a relation to the links with eager loading" do
     let!(:links){
       [Link.create(source: source, target: kibble),
         Link.create(source: source, target: water)]
@@ -124,7 +132,7 @@
 
   end
 
-  context "When using a through relation to the links with eagar loading" do
+  context "When using a through relation to the links with eager loading" do
     let!(:links){
       [Link.create(source: source, target: kibble),
         Link.create(source: source, target: water)]
@@ -139,7 +147,7 @@
 
   end
 
-  context "When eagar loading the polymorphic association" do
+  context "When eager loading the polymorphic association" do
     let(:link) { Link.create(source_id: source.id, source_type: source.class.to_s) }
     let(:source) { cat }
 
@@ -160,6 +168,7 @@
     end
 
 
+
   end
 
   context "when the association is an STI table" do

spec/support/namespaced_animal.rb

@@ -3,5 +3,9 @@ class Animal < ActiveRecord::Base
 
     self.store_full_sti_class = false
     self.table_name = "animals"
+
+    def self.polymorphic_name
+      "Animal"
+    end
   end
-end
+end