Merge pull request #21 from doliveirakn/find-by-bug

Find by bug

Author: Kyle d'Oliveira

.gitignore

@@ -17,3 +17,5 @@ spec/support/active_record.rb
 test/tmp
 test/version_tmp
 tmp
+.byebug_history
+polymorphic_integer_type_test

lib/polymorphic_integer_type.rb

@@ -1,5 +1,6 @@
 require "polymorphic_integer_type/version"
 require "polymorphic_integer_type/extensions"
 require "polymorphic_integer_type/mapping"
+require "polymorphic_integer_type/polymorphic_array_value_extension"
 
 module PolymorphicIntegerType; end

lib/polymorphic_integer_type/polymorphic_array_value_extension.rb

@@ -0,0 +1,20 @@
+module PolymorphicIntegerType
+  module PolymorphicArrayValueExtension
+    def type_to_ids_mapping
+      super.tap do |result|
+        association = @associated_table.send(:association)
+        klass = association.active_record
+        name = association.name
+
+        if klass.respond_to?("#{name}_type_mapping")
+          result.transform_keys! do |key|
+            klass.send("#{name}_type_mapping").key(key)
+          end
+        end
+        result
+      end
+    end
+  end
+end
+
+ActiveRecord::PredicateBuilder::PolymorphicArrayValue.prepend(PolymorphicIntegerType::PolymorphicArrayValueExtension)

lib/polymorphic_integer_type/version.rb

@@ -1,3 +1,3 @@
 module PolymorphicIntegerType
-  VERSION = "2.1.0"
+  VERSION = "2.2.0"
 end

polymorphic_integer_type.gemspec

@@ -18,10 +18,10 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 1.2"
+  spec.add_dependency "activerecord"
+  spec.add_development_dependency "bundler"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"
-  spec.add_development_dependency "activerecord", "4.2.0"
-  spec.add_development_dependency "mysql2", "0.3.16"
+  spec.add_development_dependency "sqlite3"
   spec.add_development_dependency "byebug"
 end

spec/polymorphic_integer_type_spec.rb

@@ -24,6 +24,17 @@
     end
   end
 
+  context "when querying the associations" do
+    let(:source) { cat }
+    let(:target) { nil }
+    it "properly finds the object with a where" do
+      expect(Link.where(source: source, id: link.id).first).to eql link
+    end
+    it "properly finds the object with a find_by" do
+      expect(Link.find_by(source: source, id: link.id)).to eql link
+    end
+  end
+
   shared_examples "proper source" do
     it "should have the proper id, type and object for the source" do
       expect(link.source_id).to eql source.id
@@ -47,12 +58,12 @@
 
     context "and the link is accessed through the associations" do
       before { link }
-      
+
       it "should have the proper source" do
         expect(source.source_links[0].source).to eql source
       end
     end
-    
+
   end
   context "When a link is given polymorphic record" do
     let(:link) { Link.create(source: source) }
@@ -137,7 +148,7 @@
 
 
   end
-  
+
   context "when the association is an STI table" do
     let(:link) { Link.create(source: source, target: whiskey) }
     let(:source) { Dog.create(name: "Bela", kind: "Dog", owner: owner) }
@@ -147,7 +158,7 @@
       expect(link.source).to eql source
     end
   end
-  
+
   context "when mapping is given inline in the belongs_to model" do
     class InlineLink < ActiveRecord::Base
       include PolymorphicIntegerType::Extensions
@@ -187,7 +198,7 @@ class InlineDrink < ActiveRecord::Base
     include_examples "proper target"
 
     it "creates foreign_type mapping method" do
-      expect(Link.source_type_mapping).to eq({0 => "Person", 1 => "Animal"})
+      expect(Link.source_type_mapping).to eq({1 => "Person", 2 => "Animal"})
       expect(InlineLink.source_type_mapping).to eq({10 => "Person", 11 => "InlineAnimal"})
     end
 

spec/spec_helper.rb

@@ -13,6 +13,7 @@
   config.before(:suite) do
     database_config = YAML.load(File.open("#{File.dirname(__FILE__)}/support/database.yml"))
     ActiveRecord::Base.establish_connection(database_config)
+    ActiveRecord::MigrationContext.new("#{File.dirname(__FILE__)}/support/migrations").migrate
   end
 
   config.around do |example|

spec/support/configuration.rb

@@ -1,4 +1,4 @@
 PolymorphicIntegerType::Mapping.configuration do |config|
-  config.add :source, {0 => "Person", 1 => "Animal"}
-  config.add :target, {0 => "Food", 1 => "Drink"}
+  config.add :source, {1 => "Person", 2 => "Animal"}
+  config.add :target, {1 => "Food", 2 => "Drink"}
 end

spec/support/database.yml

@@ -1,5 +1,5 @@
 ---
-:adapter: mysql2
+:adapter: sqlite3
 :host: localhost
 :database: polymorphic_integer_type_test
 :username: root

spec/support/migrations/1_create_link_table.rb

@@ -1,4 +1,4 @@
-class CreateLinkTable < ActiveRecord::Migration
+class CreateLinkTable < ActiveRecord::Migration[5.2]
 
   def up
     create_table :links do |t|