Minor style changes

Spacing, hash syntax to make Rubocop happy.

Author: jnraine

spec/polymorphic_integer_type_spec.rb

@@ -1,21 +1,18 @@
 require 'spec_helper'
 
 describe PolymorphicIntegerType do
+  let(:owner) { Person.create(name: "Kyle") }
+  let(:dog) { Animal.create(name: "Bela", kind: "Dog", owner: owner) }
+  let(:cat) { Animal.create(name: "Alexi", kind: "Cat") }
 
-  let(:owner) { Person.create(:name => "Kyle") }
-  let(:dog) { Animal.create(:name => "Bela", :kind => "Dog", :owner => owner) }
-  let(:cat) { Animal.create(:name => "Alexi", :kind => "Cat") }
+  let(:kibble) { Food.create(name: "Kibble") }
+  let(:chocolate) { Food.create(name: "Choclate") }
 
+  let(:milk) { Drink.create(name: "milk") }
+  let(:water) { Drink.create(name: "Water") }
+  let(:whiskey) { Drink.create(name: "Whiskey") }
 
-  let(:kibble) { Food.create(:name => "Kibble") }
-  let(:chocolate) { Food.create(:name => "Choclate") }
-
-
-  let(:milk) { Drink.create(:name => "milk") }
-  let(:water) { Drink.create(:name => "Water") }
-  let(:whiskey) { Drink.create(:name => "Whiskey") }
-
-  let(:link) { Link.create(:source => source, :target => target) }
+  let(:link) { Link.create(source: source, target: target) }
 
   context "when the source is nil" do
     let(:source) { nil }
@@ -58,13 +55,13 @@
 
   end
   context "When a link is given polymorphic record" do
-    let(:link) { Link.create(:source => source) }
+    let(:link) { Link.create(source: source) }
     let(:source) { cat }
     include_examples "proper source"
 
     context "and when it already has a polymorphic record" do
       let(:target) { kibble }
-      before { link.update_attributes(:target => target) }
+      before { link.update_attributes(target: target) }
 
       include_examples "proper source"
       include_examples "proper target"
@@ -74,13 +71,13 @@
   end
 
   context "When a link is given polymorphic id and type" do
-    let(:link) { Link.create(:source_id => source.id, :source_type => source.class.to_s) }
+    let(:link) { Link.create(source_id: source.id, source_type: source.class.to_s) }
     let(:source) { cat }
     include_examples "proper source"
 
     context "and when it already has a polymorphic id and type" do
       let(:target) { kibble }
-      before { link.update_attributes(:target_id => target.id, :target_type => target.class.to_s) }
+      before { link.update_attributes(target_id: target.id, target_type: target.class.to_s) }
       include_examples "proper source"
       include_examples "proper target"
 
@@ -90,8 +87,8 @@
 
   context "When using a relation to the links with eagar loading" do
     let!(:links){
-      [Link.create(:source => source, :target => kibble),
-        Link.create(:source => source, :target => water)]
+      [Link.create(source: source, target: kibble),
+        Link.create(source: source, target: water)]
     }
     let(:source) { cat }
 
@@ -105,8 +102,8 @@
 
   context "When using a through relation to the links with eagar loading" do
     let!(:links){
-      [Link.create(:source => source, :target => kibble),
-        Link.create(:source => source, :target => water)]
+      [Link.create(source: source, target: kibble),
+        Link.create(source: source, target: water)]
     }
     let(:source) { dog }
 
@@ -119,37 +116,37 @@
   end
 
   context "When eagar loading the polymorphic association" do
-    let(:link) { Link.create(:source_id => source.id, :source_type => source.class.to_s) }
+    let(:link) { Link.create(source_id: source.id, source_type: source.class.to_s) }
     let(:source) { cat }
 
     context "and when there are multiples sources" do
-      let(:link_2) { Link.create(:source_id => source_2.id, :source_type => source_2.class.to_s) }
+      let(:link_2) { Link.create(source_id: source_2.id, source_type: source_2.class.to_s) }
       let(:source_2) { dog }
       it "should be able to preload both associations" do
-        links = Link.includes(:source).where(:id => [link.id, link_2.id]).order(:id)
+        links = Link.includes(:source).where(id: [link.id, link_2.id]).order(:id)
         expect(links.first.source).to eql cat
         expect(links.last.source).to eql dog
       end
 
     end
 
     it "should be able to preload the association" do
-      l = Link.includes(:source).where(:id => link.id).first
+      l = Link.includes(:source).where(id: link.id).first
       expect(l.source).to eql cat
     end
 
 
   end
 
   context "when the association is an STI table" do
-    let(:link) { Link.create(:source => source, :target => whiskey) }
-    let(:source) { Dog.create(:name => "Bela", :kind => "Dog", :owner => owner) }
+    let(:link) { Link.create(source: source, target: whiskey) }
+    let(:source) { Dog.create(name: "Bela", kind: "Dog", owner: owner) }
     it "should have the proper id, type and object for the source" do
       expect(link.source_id).to eql source.id
       expect(link.source_type).to eql "Animal"
       expect(link.source).to eql source
     end
   end
 
-
+  context "when "
 end

spec/support/animal.rb

@@ -1,10 +1,6 @@
 class Animal < ActiveRecord::Base
-
   include PolymorphicIntegerType::Extensions
 
-  belongs_to :owner, :class_name => "Person"
-  has_many :source_links, :as => :source, :integer_type => true, :class_name => "Link"
-
-
-
+  belongs_to :owner, class_name: "Person"
+  has_many :source_links, as: :source, integer_type: true, class_name: "Link"
 end

spec/support/configuration.rb

@@ -1,6 +1,4 @@
 PolymorphicIntegerType::Mapping.configuration do |config|
-
   config.add :source, {0 => "Person", 1 => "Animal"}
   config.add :target, {0 => "Food", 1 => "Drink"}
-
 end

spec/support/dog.rb

@@ -1,4 +1,2 @@
 class Dog < Animal
-
-
 end

spec/support/drink.rb

@@ -1,9 +1,5 @@
 class Drink < ActiveRecord::Base
-
   include PolymorphicIntegerType::Extensions
 
-  has_many :target_links, :as => :target, :integer_type => true, :class_name => "Link"
-
-
-
+  has_many :target_links, as: :target, integer_type: true, class_name: "Link"
 end

spec/support/food.rb

@@ -1,8 +1,5 @@
 class Food < ActiveRecord::Base
-
   include PolymorphicIntegerType::Extensions
 
-  has_many :target_links, :as => :target, :integer_type => true, :class_name => "Link"
-
-
+  has_many :target_links, as: :target, integer_type: true, class_name: "Link"
 end

spec/support/link.rb

@@ -1,8 +1,6 @@
 class Link < ActiveRecord::Base
-
   include PolymorphicIntegerType::Extensions
 
-  belongs_to :source, :polymorphic => true, :integer_type => true
-  belongs_to :target, :polymorphic => true, :integer_type => true
-
+  belongs_to :source, polymorphic: true, integer_type: true
+  belongs_to :target, polymorphic: true, integer_type: true
 end

spec/support/person.rb

@@ -1,11 +1,8 @@
 class Person < ActiveRecord::Base
-
   include PolymorphicIntegerType::Extensions
 
-  has_many :pets, :class_name => "Animal", :foreign_key => :owner_id
-  has_many :source_links, :as => :source, :integer_type => true, :class_name => "Link"
-
-  has_many :pet_source_links, :class_name => "Link", :through => :pets, :source => :source_links
-
+  has_many :pets, class_name: "Animal", foreign_key: :owner_id
+  has_many :source_links, as: :source, integer_type: true, class_name: "Link"
 
+  has_many :pet_source_links, class_name: "Link", through: :pets, source: :source_links
 end