Skip to content

Commit e225ac1

Browse files
authored
Give warning for descriptions >78 instead of killing process (#74)
1 parent 7d100ae commit e225ac1

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

automated_packaging/common_functions.pm

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -150,11 +150,13 @@ sub create_release_changelog {
150150
foreach $line (@log_output) {
151151
if ($line =~ /^DESCRIPTION: */) {
152152
$description_part = substr($line, length($&), -1);
153+
153154
if (length($description_part) > 78) {
154-
print("You have to shorten PR message $description_part of $pr_url");
155-
`git reset --hard`;
156-
die "Can not add description longer than 78 charachters";
155+
print("You have to shorten PR message $description_part of $pr_url\n");
156+
print("Description should not be longer than 78 charachters, please manually shorten this description\n");
157+
push(@comment_lines, "TODO: " . "PLEASE SHORTEN THE NEXT LINE MANUALLY, IT SHOULD BE NO LONGER THAN 78 CHARS\n");
157158
}
159+
158160
print("Description $description_part has been added ... \n");
159161
push(@comment_lines, "* " . $description_part . "\n\n");
160162
}

0 commit comments

Comments
 (0)