more

Author: onurctirtir

test_package_installation/common/test_basics.sh

@@ -5,19 +5,19 @@
 #
 # Note: need to run this as root
 #
-# Usage: test_basics.sh <pg_major_version> <citus_full_version> <pg_binary_path>
+# Usage: test_basics.sh <expected_pg_major_version> <expected_citus_full_version> <pg_binary_path>
 # Example: test_basics.sh 18 14.0.0 /usr/lib/postgresql/17/bin
 
 set -euo pipefail
 
 if [ -z "$1" ] || [ -z "$2" ] || [ -z "$3" ]; then
     echo "Error: some arguments are missing." >&2
-    echo "Usage: $0 <pg_major_version> <citus_full_version> <pg_binary_path>" >&2
+    echo "Usage: $0 <expected_pg_major_version> <expected_citus_full_version> <pg_binary_path>" >&2
     exit 1
 fi
 
-PG_MAJOR_VERSION="$1"
-CITUS_FULL_VERSION="$2"
+EXPECTED_PG_MAJOR_VERSION="$1"
+EXPECTED_CITUS_FULL_VERSION="$2"
 PG_BIN="$3"
 
 ## constants and helpers
@@ -64,8 +64,8 @@ done
 ## verify PG version
 
 pg_version=$(run_psql_cmd "$FIRST_NODE_PORT" "SELECT version();")
-if [[ "$pg_version" != "PostgreSQL ${PG_MAJOR_VERSION}."* ]]; then
-    echo "Error: PostgreSQL version verification failed. Expected version to start with 'PostgreSQL ${PG_MAJOR_VERSION}.', got: $pg_version" >&2
+if [[ "$pg_version" != "PostgreSQL ${EXPECTED_PG_MAJOR_VERSION}."* ]]; then
+    echo "Error: PostgreSQL version verification failed. Expected version to start with 'PostgreSQL ${EXPECTED_PG_MAJOR_VERSION}.', got: $pg_version" >&2
     exit 1
 else
     echo "Verified PostgreSQL version: $pg_version"
@@ -74,8 +74,8 @@ fi
 ## verify Citus extension version
 
 citus_version=$(run_psql_cmd "$FIRST_NODE_PORT" "SHOW citus.version;")
-if [[ "$citus_version" != "${CITUS_FULL_VERSION}"* ]]; then
-    echo "Error: Citus version verification failed. Expected version to start with '${CITUS_FULL_VERSION}', got: $citus_version" >&2
+if [[ "$citus_version" != "${EXPECTED_CITUS_FULL_VERSION}"* ]]; then
+    echo "Error: Citus version verification failed. Expected version to start with '${EXPECTED_CITUS_FULL_VERSION}', got: $citus_version" >&2
     exit 1
 else
     echo "Verified Citus version: $citus_version"

test_package_installation/deb/install_package.sh

@@ -1,7 +1,6 @@
 #!/bin/bash
 
-# Installs PostgreSQL and Citus packages on Debian/Ubuntu, then runs
-# the cluster setup and verification test.
+# Installs PostgreSQL and Citus packages on a Debian/Ubuntu system.
 #
 # Note: need to run this as root
 #

test_package_installation/rpm/install_package.sh

@@ -1,7 +1,6 @@
 #!/bin/bash
 
-# Installs PostgreSQL and Citus packages on EL/OL (RPM-based distros), then
-# runs the cluster setup and verification test.
+# Installs PostgreSQL and Citus packages on an EL/OL (RPM-based) system.
 #
 # Note: need to run this as root
 #