feat(core): added details to "changing own ids" action log msg

Example log output:
[06:37:56][tabby] logged in from 127.0.0.1 via password auth
[06:38:05][tabby] Modified own identifiers: removed fivem:271816, removed discord:272800190639898628
[06:38:11][tabby] Modified own identifiers: added fivem:1427561
[06:38:19][tabby] Modified own identifiers: changed fivem:1427561 → fivem:271816
[06:38:24][tabby] Modified own identifiers: added discord:272800190639898628

Note: Also improved the login log action entries for better auditing.

Author: tabarra

core/routes/authentication/changeIdentifiers.ts

@@ -78,11 +78,41 @@ export default async function AuthChangeIdentifiers(ctx: AuthedCtx) {
     const vaultAdmin = txCore.adminStore.getAdminByName(ctx.admin.name);
     if (!vaultAdmin) throw new Error('Wait, what? Where is that admin?');
 
+    //Prepare log message
+    const changes: string[] = [];
+    const oldCfx = vaultAdmin.providers.citizenfx?.identifier;
+    const newCfx = citizenfxData ? citizenfxData.identifier : undefined;
+    if (oldCfx !== newCfx) {
+        if (!oldCfx && newCfx) {
+            changes.push(`added ${newCfx}`);
+        } else if (oldCfx && !newCfx) {
+            changes.push(`removed ${oldCfx}`);
+        } else if (oldCfx && newCfx) {
+            changes.push(`changed ${oldCfx} → ${newCfx}`);
+        }
+    }
+
+    const oldDiscord = vaultAdmin.providers.discord?.identifier;
+    const newDiscord = discordData ? discordData.identifier : undefined;
+    if (oldDiscord !== newDiscord) {
+        if (!oldDiscord && newDiscord) {
+            changes.push(`added ${newDiscord}`);
+        } else if (oldDiscord && !newDiscord) {
+            changes.push(`removed ${oldDiscord}`);
+        } else if (oldDiscord && newDiscord) {
+            changes.push(`changed ${oldDiscord} → ${newDiscord}`);
+        }
+    }
+
+    const logMessage = changes.length
+        ? `Modified own identifiers: ${changes.join(', ')}`
+        : 'Modified own identifiers: No changes detected.';
+
     //Edit admin and give output
     try {
         await txCore.adminStore.editAdmin(ctx.admin.name, null, citizenfxData, discordData);
 
-        ctx.admin.logAction('Changing own identifiers.');
+        ctx.admin.logAction(logMessage);
         return ctx.send<GenericApiResp>({ success: true });
     } catch (error) {
         return ctx.send<GenericApiResp>({ error: (error as Error).message });

core/routes/authentication/providerCallback.ts

@@ -74,7 +74,7 @@ export default async function AuthProviderCallback(ctx: InitializedCtx) {
         }
 
         const authedAdmin = new AuthedAdmin(vaultAdmin, sessData.csrfToken);
-        authedAdmin.logAction(`logged in from ${ctx.ip} via cfxre`);
+        authedAdmin.logAction(`logged in from ${ctx.ip} via cfxre auth`);
         txCore.metrics.txRuntime.loginOrigins.count(ctx.txVars.hostType);
         txCore.metrics.txRuntime.loginMethods.count('citizenfx');
         return ctx.send<ReactAuthDataType>(authedAdmin.getAuthData());

core/routes/authentication/verifyPassword.ts

@@ -68,13 +68,11 @@ export default async function AuthVerifyPassword(ctx: InitializedCtx) {
         } satisfies PassSessAuthType;
         ctx.sessTools.set({ auth: sessData });
 
-        txCore.logger.admin.write(vaultAdmin.name, `logged in from ${ctx.ip} via password`);
+        const authedAdmin = new AuthedAdmin(vaultAdmin, sessData.csrfToken);
+        authedAdmin.logAction(`logged in from ${ctx.ip} via password auth`);
         txCore.metrics.txRuntime.loginOrigins.count(ctx.txVars.hostType);
         txCore.metrics.txRuntime.loginMethods.count('password');
-
-        const authedAdmin = new AuthedAdmin(vaultAdmin, sessData.csrfToken)
         return ctx.send<ReactAuthDataType>(authedAdmin.getAuthData());
-
     } catch (error) {
         console.warn(`Failed to authenticate ${postBody.username} with error: ${(error as Error).message}`);
         console.verbose.dir(error);