fix(core): legacy bans causing issues on search

Author: tabarra

core/components/PlayerDatabase/databaseTypes.ts

@@ -23,6 +23,7 @@ export type DatabaseActionBaseType = {
     author: string;
     timestamp: number;
     //FIXME: the revocation object itself should be optional instead of nullable properties
+    //BUT DO REMEMBER THE `'XXX' IN YYY` ISSUE!
     revocation: {
         timestamp: number | null;
         author: string | null;
@@ -35,7 +36,7 @@ export type DatabaseActionBanType = {
 } & DatabaseActionBaseType;
 export type DatabaseActionWarnType = {
     type: 'warn';
-    expiration: false; //FIXME: remove
+    expiration: false; //FIXME: remove - BUT DO REMEMBER THE `'XXX' IN YYY` ISSUE!
     acked: boolean; //if the player has acknowledged the warning
 } & DatabaseActionBaseType;
 export type DatabaseActionType = DatabaseActionBanType | DatabaseActionWarnType;

core/components/PlayerDatabase/index.ts

@@ -206,9 +206,12 @@ export default class PlayerDatabase {
         if (hwidsArray && !Array.isArray(hwidsArray)) throw new Error('hwidsArray should be an array or undefined');
         const idsFilter = (action: DatabaseActionType) => idsArray.some((fi) => action.ids.includes(fi))
         const hwidsFilter = (action: DatabaseActionType) => {
-            if (!('hwids' in action)) return false;
-            const count = hwidsArray!.filter((fi) => action.hwids!.includes(fi)).length
-            return count >= this.config.requiredBanHwidMatches;
+            if ('hwids' in action && action.hwids){
+                const count = hwidsArray!.filter((fi) => action.hwids?.includes(fi)).length;
+                return count >= this.config.requiredBanHwidMatches;
+            } else {
+                return false;
+            }
         }
 
         try {