Skip to content

--no-git-tag on release prevents published from being set correctly #544

@TimoGlastra

Description

@TimoGlastra

We publish all packages as linked versions. For this reason we don't want a lot of tags to be created for each individual package, but rather a single tag, since all packages are created from the same commit. To achieve this we provide --no-git-tag, but this also results in the action output setting published to false.

The script that detects whether a package is published is using a regex of New Tag: to detect if the package was published. I think rather than looking at whether a tag is created, it would be good to look at whether a package has been published to NPM.

That will allow us to still then create a tag manually with a Github release. We can work around this by doing a regex on the log and see if the logs contain the lines for publishing to NPM (e.g. with PNPM it will log info Publishing "@openid4vc/oauth2").

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions