Skip to content

Commit 7f7930e

Browse files
committed
Fixed evaluate_promise parameter name in systemd module
Renamed safe_promiser to promiser to match the base class PromiseModule.evaluate_promise() signature. The parameter already receives the safe promiser via prepare_promiser_and_attributes(). Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
1 parent e6b821a commit 7f7930e

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

promise-types/systemd/systemd.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,9 @@ def prepare_promiser_and_attributes(self, promiser, attributes):
7979
return (safe_promiser, attributes)
8080

8181
def evaluate_promise(
82-
self, safe_promiser: str, attributes: Dict, metadata: Dict
82+
self, promiser: str, attributes: Dict, metadata: Dict
8383
) -> Tuple[str, List[str]]:
84-
model = self.create_attribute_object(safe_promiser, attributes)
84+
model = self.create_attribute_object(promiser, attributes)
8585
# get the status of the service
8686
try:
8787
output = self._exec_command(
@@ -106,13 +106,13 @@ def evaluate_promise(
106106
self.log_error(e.stderr.strip())
107107
return (
108108
Result.NOT_KEPT,
109-
["{safe_promiser}_show_failed".format(safe_promiser=safe_promiser)],
109+
["{safe_promiser}_show_failed".format(safe_promiser=promiser)],
110110
)
111111
# apply the changes
112112
if model.state == SystemdPromiseTypeStates.ABSENT.value:
113-
return self._service_absent(model, safe_promiser, service_status)
113+
return self._service_absent(model, promiser, service_status)
114114
else:
115-
return self._service_present(model, safe_promiser, service_status)
115+
return self._service_present(model, promiser, service_status)
116116

117117
def _service_absent(
118118
self, model: AttributeObject, safe_promiser: str, service_status: dict

0 commit comments

Comments
 (0)