Improved DNF module transaction verification

Verify that module installation, removal, and reset operations actually
succeeded before returning a repaired result. Track and report specific
package failures during the process.

Author: nickanderson

promise-types/dnf_appstream/dnf_appstream.py

@@ -340,17 +340,30 @@ def _install_module(self, mpc, base, module_name, stream, profile):
 
         # Install packages
         packages = self._get_profile_packages(mpc, module_name, stream, profile)
+        failed_packages = []
         if packages:
             for pkg in packages:
                 try:
                     base.install(pkg)
                 except dnf.exceptions.Error as e:
                     self.log_verbose(f"Failed to install package {pkg}: {e}")
+                    failed_packages.append((pkg, str(e)))
 
         base.resolve()
         base.do_transaction()
-        self.log_info(f"Module {module_name}:{stream}/{profile} installed successfully")
-        return Result.REPAIRED
+
+        # Verify installation succeeded
+        if self._is_module_installed_with_packages(mpc, module_name, stream, profile):
+            self.log_info(
+                f"Module {module_name}:{stream}/{profile} installed successfully"
+            )
+            return Result.REPAIRED
+        else:
+            self.log_error(f"Failed to install module {module_name}:{stream}/{profile}")
+            if failed_packages:
+                for pkg, error in failed_packages:
+                    self.log_error(f"  Package {pkg} failed: {error}")
+            return Result.NOT_KEPT
 
     def _remove_module(self, mpc, base, module_name, stream, profile):
         """Remove a module using DNF Python API"""
@@ -366,6 +379,7 @@ def _remove_module(self, mpc, base, module_name, stream, profile):
             self.log_verbose(f"No active stream for {module_name}, nothing to remove")
             return Result.KEPT
 
+        failed_packages = []
         if profile:
             mpc.uninstall(module_name, target_stream, profile)
             pkgs = self._get_profile_packages(mpc, module_name, target_stream, profile)
@@ -374,6 +388,7 @@ def _remove_module(self, mpc, base, module_name, stream, profile):
                     base.remove(pkg)
                 except dnf.exceptions.Error as e:
                     self.log_verbose(f"Failed to remove package {pkg}: {e}")
+                    failed_packages.append((pkg, str(e)))
         else:
             profiles = mpc.getInstalledProfiles(module_name)
             for p in profiles:
@@ -384,12 +399,23 @@ def _remove_module(self, mpc, base, module_name, stream, profile):
                         base.remove(pkg)
                     except dnf.exceptions.Error as e:
                         self.log_verbose(f"Failed to remove package {pkg}: {e}")
+                        failed_packages.append((pkg, str(e)))
 
         mpc.save()
         base.resolve(allow_erasing=True)
         base.do_transaction()
-        self.log_info(f"Module {module_name} removed successfully")
-        return Result.REPAIRED
+
+        # Verify removal succeeded
+        current_state = self._get_module_state(mpc, module_name)
+        if current_state in ["removed", "disabled"]:
+            self.log_info(f"Module {module_name} removed successfully")
+            return Result.REPAIRED
+        else:
+            self.log_error(f"Failed to remove module {module_name}")
+            if failed_packages:
+                for pkg, error in failed_packages:
+                    self.log_error(f"  Package {pkg} failed: {error}")
+            return Result.NOT_KEPT
 
     def _reset_module(self, mpc, base, module_name):
         """Reset a module using DNF Python API"""
@@ -403,8 +429,14 @@ def _reset_module(self, mpc, base, module_name):
         mpc.save()
         base.resolve()
         base.do_transaction()
-        self.log_info(f"Module {module_name} reset successfully")
-        return Result.REPAIRED
+
+        # Verify reset succeeded
+        if mpc.getModuleState(module_name) == mpc.ModuleState_DEFAULT:
+            self.log_info(f"Module {module_name} reset successfully")
+            return Result.REPAIRED
+        else:
+            self.log_error(f"Failed to reset module {module_name}")
+            return Result.NOT_KEPT
 
 
 if __name__ == "__main__":