Bug fix

Author: lbartoli79

www/archive.inc

@@ -284,7 +284,6 @@ function RestoreArchive($id)
     $isSaaSTest = (stripos($id, '_saas_') !== false);
     $saas_capture_prefix = GetSetting("cp_saas_capture_prefix");
     $isInstantTest = (stripos($id, '_instant_') !== false);
-    $isAdmin = isset($request_context) && $request_context->getUser()->isAdmin();  
 
     $ret = false;
     if (TestArchiveExpired($id)) {
@@ -313,7 +312,7 @@ function RestoreArchive($id)
                 }
             }
             //saas tests do not specifiy capture server in the URL, so we'll hardcode it
-            if ($isSaaSTest || ($isInstantTest && $isAdmin)) {
+            if ($isSaaSTest || $isInstantTest) {
                 $capture_server = GetSetting("cp_capture_$saas_capture_prefix");
                 $capture_salt = GetSetting("cp_capture_salt_$saas_capture_prefix");
             }
@@ -421,7 +420,7 @@ function RestoreArchive($id)
                     if ($deleteZip) {
                         @unlink($zipfile);
                     }
-                    if ($isInstantTest && $isAdmin) {
+                    if ($isInstantTest) {
                         ProcessUploadedTest($id);
                     }
                 }

www/common.inc

@@ -455,11 +455,6 @@ if (strlen($id)) {
             throw new ForbiddenException();
         }
 
-        $test_is_instant = (stripos($id, '_instant_') !== false);
-        if ($test_is_instant && !(isset($request_context) && $request_context->getUser()->isAdmin())) {
-            throw new ForbiddenException();
-        }
-
         $url = array_key_exists('url', $test['testinfo']) ? htmlspecialchars($test['testinfo']['url']) : null;
         $dom = array_key_exists('domElement', $test['testinfo']) ? htmlspecialchars($test['testinfo']['domElement']) : null;
         $login = array_key_exists('login', $test['testinfo']) ? htmlspecialchars($test['testinfo']['login']) : null;

www/testStatus.inc

@@ -16,12 +16,6 @@ $testInfoJson = null;
 function GetTestStatus($id, $includePosition = true)
 {
     global $request_context;
-    $isInstantTest = (stripos($id, '_instant_') !== false);
-    $isAdmin = isset($request_context) && $request_context->getUser()->isAdmin();
-    if ($isInstantTest && !$isAdmin) {
-        return array('statusCode' => 400, 'statusText' => 'Test not found', 'id' => $id);
-    }
-
     $testServer = GetServerForTest($id);
     if (isset($testServer)) {
       // Proxy the status through the server that actually owns the test