refactor(env): reorder parameters in getEnum and getNumberEnum methods for consistency

Author: cyber-hari

src/utils/env.utils.ts

@@ -440,17 +440,17 @@ export class Env {
    *
    * @typeParam T - The allowed value type (string literal types).
    * @param {string} key - The environment variable key.
-   * @param {T[]} allowedValues - Array of accepted string values.
    * @param {T} [defaultValue] - Optional fallback value.
+   * @param {T[]} allowedValues - Array of accepted string values.
    * @returns {T} The validated environment value.
    * @throws {Error} If missing or invalid.
    *
    * @example
    * // If LOG_LEVEL=debug
-   * const level = Env.getEnum('LOG_LEVEL', ['debug', 'info', 'warn', 'error'] as const, 'info');
+   * const level = Env.getEnum('LOG_LEVEL', 'info', ['debug', 'info', 'warn', 'error'] as const);
    * // 'debug' (typed as 'debug' | 'info' | 'warn' | 'error')
    */
-  static getEnum<T extends string>(key: string, allowedValues: readonly T[], defaultValue: T): T {
+  static getEnum<T extends string>(key: string, defaultValue: T, allowedValues: readonly T[]): T {
     const value = process.env[key];
 
     if (!value) {
@@ -470,15 +470,15 @@ export class Env {
    * Retrieves an enum-like numeric environment variable.
    *
    * @param {string} key - The environment variable key.
-   * @param {number[]} allowedValues - Array of accepted values.
    * @param {number} defaultValue - Default value if not present.
+   * @param {number[]} allowedValues - Array of accepted values.
    * @returns {number} The validated value.
    *
    * @example
    * // If NODE_VERSION=16
-   * const version = Env.getNumberEnum('NODE_VERSION', [14, 16, 18], 16);
+   * const version = Env.getNumberEnum('NODE_VERSION', 16, [14, 16, 18]);
    */
-  static getNumberEnum(key: string, allowedValues: number[], defaultValue: number): number {
+  static getNumberEnum(key: string, defaultValue: number, allowedValues: number[]): number {
     const value = Env.getNumber(key, defaultValue);
 
     if (!allowedValues.includes(value)) {

tests/utils/env.utils.test.ts

@@ -166,17 +166,17 @@ describe('EnvUtils', () => {
   describe('getNumberEnum', () => {
     it('returns allowed value if present', () => {
       Env.set('NUM_ENUM', '2');
-      expect(Env.getNumberEnum('NUM_ENUM', [1, 2, 3], 1)).toBe(2);
+      expect(Env.getNumberEnum('NUM_ENUM', 1, [1, 2, 3])).toBe(2);
     });
 
     it('returns allowed default if missing', () => {
       Env.delete('NUM_ENUM_MISS');
-      expect(Env.getNumberEnum('NUM_ENUM_MISS', [1, 2, 3], 3)).toBe(3);
+      expect(Env.getNumberEnum('NUM_ENUM_MISS', 3, [1, 2, 3])).toBe(3);
     });
 
     it('throws on invalid value', () => {
       Env.set('NUM_ENUM_INVALID', '4');
-      expect(() => Env.getNumberEnum('NUM_ENUM_INVALID', [1, 2, 3], 1)).toThrow(/must be one of/);
+      expect(() => Env.getNumberEnum('NUM_ENUM_INVALID', 1, [1, 2, 3])).toThrow(/must be one of/);
     });
   });
 
@@ -361,15 +361,15 @@ describe('EnvUtils', () => {
   describe('getEnum', () => {
     it('returns allowed value if present', () => {
       Env.set('EN', 'production');
-      expect(Env.getEnum('EN', ['production', 'staging'], 'production')).toBe('production');
+      expect(Env.getEnum('EN', 'production', ['production', 'staging'])).toBe('production');
     });
     it('returns allowed default if missing', () => {
       Env.delete('ENM');
-      expect(Env.getEnum('ENM', ['foo', 'bar'], 'bar')).toBe('bar');
+      expect(Env.getEnum('ENM', 'bar', ['foo', 'bar'])).toBe('bar');
     });
     it('throws on invalid value', () => {
       Env.set('EN2', 'wat');
-      expect(() => Env.getEnum('EN2', ['a', 'b'], 'c')).toThrow(/must be one of/);
+      expect(() => Env.getEnum('EN2', 'c', ['a', 'b'])).toThrow(/must be one of/);
     });
   });