fix: remove logger config in server and http timeout in config

Author: cyber-hari

jest.config.mjs

@@ -19,7 +19,7 @@ export default {
     ],
   ],
   testMatch: ['**/tests/**/*.test.ts'],
-  coveragePathIgnorePatterns: ['index.ts', 'src/servers/server.ts'],
+  coveragePathIgnorePatterns: ['index.ts', 'src/types', 'src/servers/server.ts'],
   testResultsProcessor: 'jest-sonar-reporter',
   detectOpenHandles: true
 }

src/config.ts

@@ -71,13 +71,6 @@ export let config = {
     singleLine: Env.getBoolean('LOGGER_PRETTY_SINGLE_LINE', false)
   },
 
-  http: {
-    /**
-     * Timeout for HTTP requests in milliseconds
-     */
-    timeout: Env.getNumber('HTTP_TIMEOUT', 30000)
-  },
-
   cache: {
     /**
      * Default TTL (time to live) for cache entries in seconds
@@ -137,12 +130,6 @@ export const defaultServerConfig = {
     exposeHeader: true,
     generator: () => uuid()
   },
-  logger: {
-    name: 'express_app',
-    level: 'info' as LoggerLevels,
-    prettyPrint: false,
-    singleLine: false
-  },
   metrics: {
     enable: false,
     path: '/metrics',

src/servers/server.builder.ts

@@ -565,27 +565,6 @@ export class ServerConfigBuilder {
     return this;
   }
 
-  /**
-   * Configures the logger used by the server.
-   *
-   * @param opts - Logger configuration options
-   * @returns The builder instance for chaining
-   * @default { name: 'express_app', level: 'info', prettyPrint: true in dev, singleLine: false }
-   *
-   * @example
-   * ```typescript
-   * builder.withLogger({
-   *   level: 'info',
-   *   prettyPrint: true,
-   *   singleLine: false
-   * })
-   * ```
-   */
-  withLogger(opts: Partial<NonNullable<ServerConfig['logger']>>): this {
-    this.mergeConfig('logger', opts as NonNullable<ServerConfig['logger']>);
-    return this;
-  }
-
   /**
    * Adds a static folder to serve files from.
    *

src/servers/server.ts

@@ -40,7 +40,7 @@ import client, { Counter, Histogram } from 'prom-client';
 import { NotFoundException } from '../utils/exception.utils';
 import fs from 'fs';
 import { apiReference } from '@scalar/express-api-reference';
-import { defaultServerConfig, setConfig } from '../config';
+import { defaultServerConfig } from '../config';
 import { deepObjMerge } from '../utils/obj.utils';
 import { fileExists } from '../utils/fs.utils';
 import { Socket } from 'net';
@@ -174,19 +174,6 @@ export class ExpressServer {
       this.healthChecks.push(...config.healthCheck.checks);
     }
 
-    // Logger
-    if (this.config.logger) {
-      const { name, level, prettyPrint: pretty, singleLine } = this.config.logger;
-      setConfig({
-        logger: {
-          name: name ?? 'express_app',
-          level: level ?? 'info',
-          pretty: pretty ?? Env.isDev(),
-          singleLine: singleLine ?? false
-        }
-      });
-    }
-
     // Set global prefix (normalize to empty string or "/prefix" without trailing slash)
     this.globalPrefix = this.normalizePath(this.config.globalPrefix ?? '', false);
 

src/types/server.ts

@@ -27,7 +27,6 @@ import { ExpressServer } from '../servers/server';
 import { HelmetOptions } from 'helmet';
 import { CompressionOptions } from 'compression';
 import { CookieParseOptions } from 'cookie-parser';
-import { LoggerLevels } from '../utils/logger.utils';
 import http from 'http';
 import { CorsOptions } from 'cors';
 import { ToggleConfig } from '.';
@@ -237,23 +236,6 @@ export interface ServerConfig {
     withGlobalPrefix?: boolean;
   };
 
-  /** Logger settings
-   *  - name: 'express_app'
-   *  - level: 'info'
-   *  - prettyPrint: default true if process.env.NODE_ENV === 'development'
-   *  - singleLine: false
-   */
-  logger?: {
-    /** Logger name (default: 'express_app') */
-    name?: string;
-    /** Log level (default: 'info') */
-    level?: LoggerLevels;
-    /** Pretty print (default: true in dev) */
-    prettyPrint?: boolean;
-    /** Single line output for pretty print (default: false) */
-    singleLine?: boolean;
-  };
-
   /** Prometheus metrics
    *  - enable: false
    *  - path: '/metrics'

src/utils/context-store.utils.ts

@@ -37,12 +37,15 @@ export interface Store {
  * Add new symbols here to avoid duplication.
  */
 export const StoreKeys = {
-  LOGGER: Symbol('logger'),
-  REQUEST_ID: Symbol('requestId'),
-  USER_ID: Symbol('userId'),
-  TENANT_ID: Symbol('tenantId'),
-  TRACE_ID: Symbol('traceId'),
-  CORRELATION_ID: Symbol('correlationId')
+  LOGGER: Symbol('LOGGER'),
+  REQUEST_ID: Symbol('REQUEST_ID'),
+  USER: Symbol('USER'),
+  SESSION: Symbol('SESSION'),
+  TRANSACTION_ID: Symbol('TRANSACTION_ID'),
+  USER_ID: Symbol('USER_ID'),
+  TENANT_ID: Symbol('TENANT_ID'),
+  TRACE_ID: Symbol('TRACE_ID'),
+  CORRELATION_ID: Symbol('CORRELATION_ID')
 };
 
 /**

tests/config.test.ts

@@ -105,9 +105,6 @@ describe('config', () => {
       },
       cache: {
         defaultTtl: 3600000
-      },
-      http: {
-        timeout: 30000
       }
     });
   });

tests/servers/server.builder.test.ts

@@ -204,12 +204,6 @@ describe('ServerConfigBuilder', () => {
     expect((config as any).cookieParser).toEqual({ decode: expect.any(Function) });
   });
 
-  it('should configure logger', () => {
-    const config = new ServerConfigBuilder().withLogger({ level: 'info', prettyPrint: true }).disableOpenApi().build();
-    expect(config.logger?.level).toBe('info');
-    expect(config.logger?.prettyPrint).toBe(true);
-  });
-
   it('should configure microservice', () => {
     const config = new ServerConfigBuilder()
       .withMicroService({

tests/utils/middleware.utils.test.ts

@@ -20,9 +20,6 @@ jest.mock('../../src/utils/logger.utils', () => ({
 jest.mock('../../src/utils/env.utils', () => ({
   Env: { isDev: jest.fn() }
 }));
-jest.mock('../../src/config', () => ({
-  config: { http: { timeout: 30000 } }
-}));
 jest.mock('../../src/utils/context-store.utils', () => {
   const original = jest.requireActual('../../src/utils/context-store.utils');
   return {