some fixup:

  - target index may change
  - move callback
  - onClick get called from main Thread

Author: tux-mind

cSploit/res/values/strings.xml

@@ -514,4 +514,6 @@
     <string name="new_ruby_found">A new version for ruby is available, do you want to upgrade ?</string>
     <string name="new_msf_found">A new msf version is available, do you want to upgrade ?</string>
     <string name="msf_status">MetaSploit Status</string>
+    <string name="mitm_ss_select_target_title">Select target</string>
+    <string name="mitm_ss_select_target_prompt">Select %s ?</string>
 </resources>

cSploit/src/org/csploit/android/core/System.java

@@ -1029,10 +1029,6 @@ public static Target getTarget(int index){
     return mTargets.get(index);
   }
 
-  public static int getTargetPosition (Target t) {
-    return mTargets.indexOf(t);
-  }
-
   public static boolean hasTarget(Target target){
     return mTargets.contains(target);
   }
@@ -1041,6 +1037,14 @@ public static void setCurrentTarget(int index){
     mCurrentTarget = index;
   }
 
+  public static void setCurrentTarget(Target target) {
+    int index = mTargets.indexOf(target);
+    if(index != -1)
+      setCurrentTarget(index);
+    else
+      Logger.error("target '" + target + "' not found");
+  }
+
   public static Target getCurrentTarget(){
     return getTarget(mCurrentTarget);
   }

cSploit/src/org/csploit/android/plugins/mitm/Sniffer.java

@@ -54,7 +54,7 @@
 import java.util.ArrayList;
 import java.util.Collections;
 
-public class Sniffer extends AppCompatActivity
+public class Sniffer extends AppCompatActivity implements AdapterView.OnItemClickListener
 {
   private static final String[] SORT = {
     "Bandwidth ↓",
@@ -296,52 +296,18 @@ public void onCreate(Bundle savedInstanceState){
     mSpoofSession = new SpoofSession(false, false, null, null);
 
     mSortSpinner.setAdapter(new ArrayAdapter<String>(this, android.R.layout.simple_spinner_item, SORT));
-    mSortSpinner.setOnItemSelectedListener(new OnItemSelectedListener(){
-      public void onItemSelected(AdapterView<?> adapter, View view, int position, long id){
+    mSortSpinner.setOnItemSelectedListener(new OnItemSelectedListener() {
+      public void onItemSelected(AdapterView<?> adapter, View view, int position, long id) {
         mSortType = position;
       }
 
-      public void onNothingSelected(AdapterView<?> arg0){
+      public void onNothingSelected(AdapterView<?> arg0) {
       }
     });
 
     mListView.setAdapter(mAdapter);
 
-    mListView.setOnItemClickListener(new AdapterView.OnItemClickListener() {
-      @Override
-      public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
-        final Target t = System.getTargetByAddress(mAdapter.getByPosition(position).mAddress);
-
-        new ConfirmDialog("Select target", "Select " + t.getAddress().getHostAddress() + "?", Sniffer.this, new ConfirmDialog.ConfirmDialogListener() {
-          @Override
-          public void onConfirm() {
-            new Thread(new Runnable() {
-              @Override
-              public void run() {
-                setStoppedState();
-
-                startActivity(new Intent(Sniffer.this,
-                        ActionActivity.class));
-
-                overridePendingTransition(R.anim.slide_in_left,
-                        R.anim.slide_out_left);
-              }
-            }).start();
-
-            System.setCurrentTarget(System.getTargetPosition(t));
-            Toast.makeText(Sniffer.this,
-                    getString(R.string.selected_) + System.getCurrentTarget(),
-                    Toast.LENGTH_SHORT).show();
-          }
-
-          @Override
-          public void onCancel() {
-          }
-        }).show();
-
-
-      }
-     });
+    mListView.setOnItemClickListener(this);
 
     mSniffToggleButton.setOnClickListener(new View.OnClickListener(){
       @Override
@@ -370,6 +336,40 @@ public void onCancel(){
     }).show();
   }
 
+  @Override
+  public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
+    String address = mAdapter.getByPosition(position).mAddress;
+    final Target t = System.getTargetByAddress(address);
+
+    if (t == null)
+      return;
+
+    new ConfirmDialog(getString(R.string.mitm_ss_select_target_title),
+            String.format(getString(R.string.mitm_ss_select_target_prompt), address),
+            Sniffer.this, new ConfirmDialog.ConfirmDialogListener() {
+      @Override
+      public void onConfirm() {
+        System.setCurrentTarget(t);
+
+        setStoppedState();
+
+        Toast.makeText(Sniffer.this,
+                getString(R.string.selected_) + System.getCurrentTarget(),
+                Toast.LENGTH_SHORT).show();
+
+        startActivity(new Intent(Sniffer.this,
+                ActionActivity.class));
+
+        overridePendingTransition(R.anim.slide_in_left,
+                R.anim.slide_out_left);
+      }
+
+      @Override
+      public void onCancel() {
+      }
+    }).show();
+  }
+
   public synchronized int getSortType(){
     return mSortType;
   }
@@ -404,9 +404,9 @@ public void run() {
         mSniffToggleButton.setChecked(false);
       }
     });
-    }
+  }
 
-    private void setSpoofErrorState(final String error){
+  private void setSpoofErrorState(final String error){
     Sniffer.this.runOnUiThread(new Runnable(){
       @Override
       public void run(){