partially fixes #372

Author: tux-mind

cSploit/src/org/csploit/android/services/UpdateService.java

@@ -274,7 +274,7 @@ private void finishNotification() {
     Intent contentIntent;
 
     errorOccurred = mCurrentTask.errorOccurred;
-    contentIntent = mCurrentTask.contentIntent;
+    contentIntent = mCurrentTask.haveIntent() ? mCurrentTask.buildIntent() : null;
 
     if(errorOccurred || contentIntent==null){
       Logger.debug("deleting notifications");

cSploit/src/org/csploit/android/update/ApkUpdate.java

@@ -19,9 +19,19 @@ public ApkUpdate(Context context, String url, String version) {
     this.version = version;
     name = String.format("cSploit-%s.apk", version);
     path = String.format("%s/%s", System.getStoragePath(), name);
-    contentIntent = new Intent(Intent.ACTION_VIEW);
-    contentIntent.setDataAndType(Uri.fromFile(new File(path)), "application/vnd.android.package-archive");
-    contentIntent.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
     prompt = String.format(context.getString(R.string.new_apk_found), version);
   }
+
+  @Override
+  public boolean haveIntent() {
+    return true;
+  }
+
+  @Override
+  public Intent buildIntent() {
+    Intent intent = new Intent(Intent.ACTION_VIEW);
+    intent.setDataAndType(Uri.fromFile(new File(path)), "application/vnd.android.package-archive");
+    intent.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
+    return intent;
+  }
 }

cSploit/src/org/csploit/android/update/Update.java

@@ -21,8 +21,6 @@ public abstract class Update implements Serializable {
           compression;
   public archiveAlgorithm
           archiver;
-  public Intent
-          contentIntent;
   public boolean
           skipRoot,
           fixShebang,
@@ -42,11 +40,18 @@ public void reset() {
       version = null;
       compression = null;
       archiver = null;
-      contentIntent = null;
       wipeOnFail = fixShebang = errorOccurred = skipRoot = false;
     }
   }
 
+  public boolean haveIntent() {
+    return false;
+  }
+
+  public Intent buildIntent() {
+    return null;
+  }
+
   public enum compressionAlgorithm {
     none,
     gzip,