fixes #122

Author: tux-mind

cSploit/src/org/csploit/android/SettingsActivity.java

@@ -303,26 +303,23 @@ public void onSharedPreferenceChanged(SharedPreferences sharedPreferences, Strin
       }
 
       if (key.equals("PREF_HTTP_PROXY_PORT")) {
-        if (port == 0)
-          port = 8080;
-        mProxyPort.setText(Integer.toString(port));
         System.HTTP_PROXY_PORT = port;
       } else if (key.equals("PREF_HTTP_SERVER_PORT")) {
-        if (port == 0)
-          port = 8081;
-        mServerPort.setText(Integer.toString(port));
         System.HTTP_SERVER_PORT = port;
       } else if (key.equals("PREF_HTTPS_REDIRECTOR_PORT")) {
-        if (port == 0)
-          port = 8082;
-        mRedirectorPort.setText(Integer.toString(port));
         System.HTTPS_REDIR_PORT = port;
       } else if (key.equals("MSF_RPC_PORT")) {
-        if (port == 0)
-          port = 55553;
-        mMsfPort.setText(Integer.toString(port));
         System.MSF_RPC_PORT = port;
       }
+
+      if(port == 0) {
+        // reset to default value
+        port = getDefaultPortForKey(key);
+
+        SharedPreferences.Editor editor = sharedPreferences.edit();
+        editor.putString(key, Integer.toString(port));
+        editor.apply();
+      }
     } else if (key.equals("PREF_HTTP_MAX_BUFFER_SIZE")) {
       int maxBufferSize;
 
@@ -364,6 +361,21 @@ public void onSharedPreferenceChanged(SharedPreferences sharedPreferences, Strin
     System.onSettingChanged(key);
   }
 
+  private int getDefaultPortForKey(String key) {
+    switch(key) {
+      case "PREF_HTTP_PROXY_PORT":
+        return 8080;
+      case "PREF_HTTP_SERVER_PORT":
+        return 8081;
+      case "PREF_HTTPS_REDIRECTOR_PORT":
+        return 8082;
+      case "MSF_RPC_PORT":
+        return 55553;
+      default:
+        return 0;
+    }
+  }
+
   private void onMsfEnabled() {
     // use mReceiver as "already did that"
     if (mReceiver != null)