Skip to content

Commit c9567f2

Browse files
committed
* ruby_atomic.h (ATOMIC_CAS): added.
* signal.c (ruby_atomic_compare_and_swap): ATOMIC_CAS implementation for non-VC/gcc platform. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@44950 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
1 parent 6d8b985 commit c9567f2

4 files changed

Lines changed: 35 additions & 1 deletion

File tree

ChangeLog

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
Fri Feb 14 16:21:28 2014 NAKAMURA Usaku <usa@ruby-lang.org>
2+
3+
* ruby_atomic.h (ATOMIC_CAS): added.
4+
5+
* signal.c (ruby_atomic_compare_and_swap): ATOMIC_CAS implementation
6+
for non-VC/gcc platform.
7+
18
Fri Feb 14 15:56:27 2014 Tanaka Akira <akr@fsij.org>
29

310
* lib/resolv.rb: Ignore name servers which cause EAFNOSUPPORT on

ruby_atomic.h

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ typedef unsigned int rb_atomic_t; /* Anything OK */
1313
# define ATOMIC_DEC(var) __sync_fetch_and_sub(&(var), 1)
1414
# define ATOMIC_OR(var, val) __sync_or_and_fetch(&(var), (val))
1515
# define ATOMIC_EXCHANGE(var, val) __sync_lock_test_and_set(&(var), (val))
16+
# define ATOMIC_CAS(var, oldval, newval) __sync_val_compare_and_swap(&(var), (oldval), (newval))
1617

1718
# define ATOMIC_SIZE_ADD(var, val) __sync_fetch_and_add(&(var), (val))
1819
# define ATOMIC_SIZE_SUB(var, val) __sync_fetch_and_sub(&(var), (val))
@@ -49,7 +50,17 @@ rb_w32_atomic_or(volatile rb_atomic_t *var, rb_atomic_t val)
4950
# define ATOMIC_OR(var, val) _InterlockedOr(&(var), (val))
5051
#endif
5152
# define ATOMIC_EXCHANGE(var, val) InterlockedExchange(&(var), (val))
53+
# define ATOMIC_CAS(var, oldval, newval) InterlockedCompareExchange(&(var), (newval), (oldval))
5254

55+
# if defined _MSC_VER && _MSC_VER <= 1200
56+
static inline rb_atomic_t
57+
rb_w32_atomic_cas(volatile rb_atomic_t *var, rb_atomic_t oldval, rb_atomic_t newval)
58+
{
59+
return (rb_atomic_t)InterlockedCompareExchange((PVOID *)var, (PVOID)newval, (PVOID)oldval);
60+
}
61+
# undef ATOMIC_CAS
62+
# define ATOMIC_CAS(var, oldval, newval) rb_w32_atomic_cas(&(var), (oldval), (newval))
63+
# endif
5364
# ifdef _M_AMD64
5465
# define ATOMIC_SIZE_ADD(var, val) InterlockedExchangeAdd64(&(var), (val))
5566
# define ATOMIC_SIZE_SUB(var, val) InterlockedExchangeAdd64(&(var), -(val))
@@ -74,6 +85,7 @@ typedef unsigned int rb_atomic_t;
7485
# define ATOMIC_DEC(var) atomic_dec_uint(&(var))
7586
# define ATOMIC_OR(var, val) atomic_or_uint(&(var), (val))
7687
# define ATOMIC_EXCHANGE(var, val) atomic_swap_uint(&(var), (val))
88+
# define ATOMIC_CAS(var, oldval, newval) atomic_cas_uint(&(var), (oldval), (newval))
7789

7890
# if SIZEOF_SIZE_T == SIZEOF_LONG
7991
# define ATOMIC_SIZE_ADD(var, val) atomic_add_long(&(var), (val))
@@ -93,12 +105,16 @@ typedef unsigned int rb_atomic_t;
93105
typedef int rb_atomic_t;
94106
#define NEED_RUBY_ATOMIC_EXCHANGE
95107
extern rb_atomic_t ruby_atomic_exchange(rb_atomic_t *ptr, rb_atomic_t val);
108+
extern rb_atomic_t ruby_atomic_compare_and_swap(rb_atomic_t *ptr,
109+
rb_atomic_t cmp,
110+
rb_atomic_t newval);
96111

97112
# define ATOMIC_SET(var, val) (void)((var) = (val))
98113
# define ATOMIC_INC(var) ((var)++)
99114
# define ATOMIC_DEC(var) ((var)--)
100115
# define ATOMIC_OR(var, val) ((var) |= (val))
101116
# define ATOMIC_EXCHANGE(var, val) ruby_atomic_exchange(&(var), (val))
117+
# define ATOMIC_CAS(var, oldval, newval) ruby_atomic_compare_and_swap(&(var), (oldval), (newval))
102118

103119
# define ATOMIC_SIZE_ADD(var, val) (void)((var) += (val))
104120
# define ATOMIC_SIZE_SUB(var, val) (void)((var) -= (val))

signal.c

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,17 @@ ruby_atomic_exchange(rb_atomic_t *ptr, rb_atomic_t val)
2929
*ptr = val;
3030
return old;
3131
}
32+
33+
rb_atomic_t
34+
ruby_atomic_compare_and_swap(rb_atomic_t *ptr, rb_atomic_t cmp,
35+
rb_atomic_t newval)
36+
{
37+
rb_atomic_t old = *ptr;
38+
if (old == cmp) {
39+
*ptr = newval;
40+
}
41+
return old;
42+
}
3243
#endif
3344

3445
#if defined(__BEOS__) || defined(__HAIKU__)

version.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#define RUBY_VERSION "1.9.3"
2-
#define RUBY_PATCHLEVEL 530
2+
#define RUBY_PATCHLEVEL 531
33

44
#define RUBY_RELEASE_DATE "2014-02-14"
55
#define RUBY_RELEASE_YEAR 2014

0 commit comments

Comments
 (0)