Promoting various logging events

This should reduce the need to get swamped by the trace level
logging, and bubble up issues that might have been lost at debug.

Fixes #199

Author: blackspherefollower

Buttplug.Client/ButtplugWSClient.cs

@@ -83,7 +83,7 @@ public ButtplugWSClient(string aClientName)
             _bpLogManager = new ButtplugLogManager();
             _bpLogger = _bpLogManager.GetLogger(GetType());
             _parser = new ButtplugJsonMessageParser(_bpLogManager);
-            _bpLogger.Trace("Finished setting up ButtplugClient");
+            _bpLogger.Info("Finished setting up ButtplugClient");
             _owningDispatcher = Dispatcher.CurrentDispatcher;
             _tokenSource = new CancellationTokenSource();
         }

Buttplug.Components.Controls/ButtplugTabControl.xaml.cs

@@ -116,7 +116,7 @@ private ButtplugServer InitializeButtplugServer(string aServerName, uint aMaxPin
                 }
                 catch (PlatformNotSupportedException e)
                 {
-                    _guiLog.Warn(e, "Something went wrong whilst setting up bluetooth.");
+                    _guiLog.Error(e, "Something went wrong whilst setting up bluetooth.");
                 }
             }
             else
@@ -209,12 +209,12 @@ public void SetServerDetails(string serverName, uint maxPingTime)
             }
             catch (Exception)
             {
-                _guiLog.Error("Cannot retreive Release ID for OS! Will not load bluetooth manager.");
+                _guiLog.Warn("Cannot retreive Release ID for OS! Will not load bluetooth manager.");
             }
 
             if (!UWPBluetoothManager.HasRegistryKeysSet())
             {
-                _guiLog.Error("Registry keys not set for UWP bluetooth API security. This may cause Bluetooth devices to not be seen.");
+                _guiLog.Warn("Registry keys not set for UWP bluetooth API security. This may cause Bluetooth devices to not be seen.");
 
                 // Only show this if we're running a full application.
                 if (Application.Current != null)

Buttplug.Core/ButtplugJsonMessageParser.cs

@@ -24,7 +24,7 @@ public class ButtplugJsonMessageParser
         public ButtplugJsonMessageParser([NotNull] IButtplugLogManager aLogManager)
         {
             _bpLogger = aLogManager.GetLogger(GetType());
-            _bpLogger.Debug($"Setting up {GetType().Name}");
+            _bpLogger.Info($"Setting up {GetType().Name}");
             IEnumerable<Type> allTypes;
 
             // Some classes in the library may not load on certain platforms due to missing symbols.
@@ -84,7 +84,7 @@ public ButtplugMessage[] Deserialize(string aJsonMsg)
             }
             catch (JsonReaderException e)
             {
-                res.Add(_bpLogger.LogErrorMsg(ButtplugConsts.SystemMsgId, ErrorClass.ERROR_MSG, "Not valid JSON"));
+                res.Add(_bpLogger.LogErrorMsg(ButtplugConsts.SystemMsgId, ErrorClass.ERROR_MSG, $"Not valid JSON: {aJsonMsg} - {e.Message}"));
                 return res.ToArray();
             }
 

Buttplug.Server.Managers.UWPBluetoothManager/UWPBluetoothManager.cs

@@ -35,7 +35,7 @@ public static bool HasRegistryKeysSet()
         public UWPBluetoothManager(IButtplugLogManager aLogManager)
             : base(aLogManager)
         {
-            BpLogger.Debug("Loading UWP Bluetooth Manager");
+            BpLogger.Info("Loading UWP Bluetooth Manager");
             _currentlyConnecting = new List<ulong>();
 
             // Introspect the ButtplugDevices namespace for all Factory classes, then create instances of all of them.
@@ -120,19 +120,19 @@ where x.MayBeDevice(aEvent.Advertisement)
         private void OnWatcherStopped(BluetoothLEAdvertisementWatcher aObj,
                                       BluetoothLEAdvertisementWatcherStoppedEventArgs aEvent)
         {
-            BpLogger.Trace("Stopped BLE Scanning");
+            BpLogger.Info("Stopped BLE Scanning");
             InvokeScanningFinished();
         }
 
         public override void StartScanning()
         {
-            BpLogger.Trace("Starting BLE Scanning");
+            BpLogger.Info("Starting BLE Scanning");
             _bleWatcher.Start();
         }
 
         public override void StopScanning()
         {
-            BpLogger.Trace("Stopping BLE Scanning");
+            BpLogger.Info("Stopping BLE Scanning");
             _bleWatcher.Stop();
         }
 

Buttplug.Server.Managers.XInputGamepadManager/XInputGamepadManager.cs

@@ -8,12 +8,12 @@ public class XInputGamepadManager : DeviceSubtypeManager
         public XInputGamepadManager(IButtplugLogManager aLogManager)
             : base(aLogManager)
         {
-            BpLogger.Debug("Loading XInput Gamepad Manager");
+            BpLogger.Info("Loading XInput Gamepad Manager");
         }
 
         public override void StartScanning()
         {
-            BpLogger.Trace("XInputGamepadManager start scanning");
+            BpLogger.Info("XInputGamepadManager start scanning");
             var controllers = new[]
             {
                 new Controller(UserIndex.One),
@@ -38,7 +38,7 @@ public override void StartScanning()
         public override void StopScanning()
         {
             // noop
-            BpLogger.Trace("XInputGamepadManager stop scanning");
+            BpLogger.Info("XInputGamepadManager stop scanning");
         }
 
         public override bool IsScanning()

Buttplug.Server/ButtplugServer.cs

@@ -73,7 +73,7 @@ public ButtplugServer([NotNull] string aServerName, uint aMaxPingTime, DeviceMan
 
             _bpLogManager = new ButtplugLogManager();
             _bpLogger = _bpLogManager.GetLogger(GetType());
-            _bpLogger.Trace("Setting up ButtplugServer");
+            _bpLogger.Debug("Setting up ButtplugServer");
             _parser = new ButtplugJsonMessageParser(_bpLogManager);
             if (aDeviceManager != null)
             {
@@ -84,7 +84,7 @@ public ButtplugServer([NotNull] string aServerName, uint aMaxPingTime, DeviceMan
                 _deviceManager = new DeviceManager(_bpLogManager);
             }
 
-            _bpLogger.Trace("Finished setting up ButtplugServer");
+            _bpLogger.Info("Finished setting up ButtplugServer");
             _deviceManager.DeviceMessageReceived += DeviceMessageReceivedHandler;
             _deviceManager.ScanningFinished += ScanningFinishedHandler;
             _bpLogManager.LogMessageReceived += LogMessageReceivedHandler;

Buttplug.Server/DeviceManager.cs

@@ -30,7 +30,7 @@ public DeviceManager(IButtplugLogManager aLogManager)
         {
             _bpLogManager = aLogManager;
             _bpLogger = _bpLogManager.GetLogger(GetType());
-            _bpLogger.Trace("Setting up DeviceManager");
+            _bpLogger.Info("Setting up DeviceManager");
             _sentFinished = true;
             _devices = new Dictionary<uint, IButtplugDevice>();
             _deviceIndexCounter = 0;
@@ -59,11 +59,11 @@ private void DeviceAddedHandler(object aObj, DeviceAddedEventArgs aEvent)
                 select x;
             if (duplicates.Any())
             {
-                _bpLogger.Trace($"Already have device {aEvent.Device.Name} in Devices list");
+                _bpLogger.Debug($"Already have device {aEvent.Device.Name} in Devices list");
                 return;
             }
 
-            _bpLogger.Debug($"Adding Device {aEvent.Device.Name} at index {deviceIndex}");
+            _bpLogger.Info($"Adding Device {aEvent.Device.Name} at index {deviceIndex}");
             _devices.Add(deviceIndex, aEvent.Device);
             aEvent.Device.DeviceRemoved += DeviceRemovedHandler;
             var msg = new DeviceAdded(deviceIndex, aEvent.Device.Name, GetAllowedMessageTypesAsStrings(aEvent.Device).ToArray());

Buttplug.Server/DeviceSubtypeManager.cs

@@ -19,7 +19,7 @@ protected DeviceSubtypeManager([NotNull] IButtplugLogManager aLogManager)
         {
             LogManager = aLogManager;
             BpLogger = aLogManager.GetLogger(GetType());
-            BpLogger.Trace($"Setting up Device Manager {GetType().Name}");
+            BpLogger.Debug($"Setting up Device Manager {GetType().Name}");
         }
 
         protected void InvokeDeviceAdded([NotNull] DeviceAddedEventArgs aEventArgs)