Skip to content

Commit 593e4cc

Browse files
committed
chore: Clean up bluetooth logging messages
Debug was getting spammed due to a missing context check that meant devices with nameprefixes but no names passed too far into the filter.
1 parent 57246e1 commit 593e4cc

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

Buttplug.Server.Managers.UWPBluetoothManager/UWPBluetoothDeviceFactory.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,13 +41,14 @@ public bool MayBeDevice(string advertName, List<Guid> advertGUIDs)
4141
continue;
4242
}
4343

44-
_bpLogger.Debug("Found " + advertName + " via NamePrefix " + deviceInfoNamePrefix);
44+
_bpLogger.Debug($"Found {advertName} via NamePrefix {deviceInfoNamePrefix}");
4545
return true;
4646
}
4747
}
4848

49-
if (_deviceInfo.Names.Any() && !_deviceInfo.Names.Contains(advertName))
49+
if (_deviceInfo.Names.Any() && !_deviceInfo.Names.Contains(advertName) || !_deviceInfo.Names.Any())
5050
{
51+
_bpLogger.Trace($"Dropping query for {advertName}.");
5152
return false;
5253
}
5354

@@ -57,7 +58,7 @@ public bool MayBeDevice(string advertName, List<Guid> advertGUIDs)
5758
return true;
5859
}
5960

60-
_bpLogger.Debug("Found " + advertName + " for " + _deviceInfo.GetType() + " with services " + advertGUIDs);
61+
_bpLogger.Trace("Found " + advertName + " for " + _deviceInfo.GetType() + " with services " + advertGUIDs);
6162
foreach (var s in _deviceInfo.Services)
6263
{
6364
_bpLogger.Trace("Expecting " + s);

0 commit comments

Comments
 (0)